Change the signature of Client.create_message() to be more friendly

Author: mvantellingen

CHANGES

@@ -1,7 +1,9 @@
 2.0.0 (unreleased)
 ------------------
  - Default values of optional elements are not set by default anymore (#423)
-
+ - The call signature for Client.create_message() was changed. It now requires
+   the service argument:
+     ``Client.create_message(service, operation_name, *args, **kwargs)``
 
 1.6.0 (2017-04-27)
 ------------------

docs/client.rst

@@ -18,11 +18,11 @@ Caching of WSDL and XSD files
 ------------------------------
 When the client is initialised it will automaticaly retrieve the wsdl file
 passed as argument. This wsdl file generally references various other wsdl and
-xsd files. By default Zeep doesn't cache these files but it is however 
+xsd files. By default Zeep doesn't cache these files but it is however
 advised to enable this for performance reasons.
 
 Please see :ref:`transport_caching` how to enable this. To make it easy to
-use the ``zeep.CachingClient()`` automatically creates a Transport object 
+use the ``zeep.CachingClient()`` automatically creates a Transport object
 with SqliteCache enabled.
 
 
@@ -49,7 +49,7 @@ For example to let zeep return the raw response directly instead of processing
 it you can do the following:
 
 .. code-block:: python
-    
+
     from zeep import Client
     from zeep import xsd
 
@@ -69,7 +69,7 @@ The ServiceProxy object
 The ServiceProxy object is a simple object which will check if an operation
 exists for attribute or item requested.  If the operation exists then it will
 return an OperationProxy object (callable) which is responsible for calling the
-operation on the binding. 
+operation on the binding.
 
 
 .. code-block:: python
@@ -82,12 +82,12 @@ operation on the binding.
     # service is a ServiceProxy object.  It will check if there
     # is an operation with the name `X` defined in the binding
     # and if that is the case it will return an OperationProxy
-    client.service.X()  
+    client.service.X()
 
-    # The operation can also be called via an __getitem__ call. 
-    # This is usefull if the operation name is not a valid 
+    # The operation can also be called via an __getitem__ call.
+    # This is usefull if the operation name is not a valid
     # python attribute name.
-    client.service['X-Y']()  
+    client.service['X-Y']()
 
 
 Using non-default bindings
@@ -112,7 +112,7 @@ Creating new ServiceProxy objects
 ---------------------------------
 There are situations where you either need to change the SOAP address from the
 one which is defined within the WSDL or the WSDL doesn't define any service
-elements. This can be done by creating a new ServiceProxy using the 
+elements. This can be done by creating a new ServiceProxy using the
 ``Client.create_service()`` method.
 
 .. code-block:: python
@@ -125,4 +125,19 @@ elements. This can be done by creating a new ServiceProxy using the
         '{http://my-target-namespace-here}myBinding',
         'http://my-endpoint.com/acceptance/')
 
-    service.submit('something') 
+    service.submit('something')
+
+
+Creating the raw XML documents
+------------------------------
+When you want zeep to build and return the XML instead of sending it to the
+server you can use the ``Client.create_message()`` call. It requires then
+ServiceProxy as first argument and the operation name as second argument.
+
+
+.. code-block:: python
+
+    from zeep import Client
+
+    client = Client('http://my-endpoint.com/production.svc?wsdl')
+    node = client.create_message(client.service, 'myOperation', user='hi')

docs/reporting_bugs.rst

@@ -19,7 +19,7 @@ There are basically three majors parts where bugs can happen, these are:
 3. Parsing the XML from the response
 
 
-The first one is usually pretty easy to debug if the WSDL is publicly 
+The first one is usually pretty easy to debug if the WSDL is publicly
 accessible. If that isn't the case then you might be able to make it anonymous.
 
 
@@ -47,9 +47,9 @@ args / kwargs you normally pass.
 
     client = Client('YOUR-WSDL')
 
-    # client.service.OPERATION_NAME(args, kwargs) becomes
-    node = client.service._binding.create_message(
-        'OPERATION_NAME', args, kwargs)
+    # client.service.OPERATION_NAME(*args, **kwargs) becomes
+    node = client.create_message(
+        client.service, 'OPERATION_NAME', *args, **kwargs)
 
     print(etree.tostring(node, pretty_print=True))
 
@@ -62,7 +62,7 @@ The first step is to retrieve the XML which is returned from the server, You
 need to enable debugging for this. Please see :ref:`debugging` for a detailed
 description.
 
-The next step is to create a python script which exposes the problem, an 
+The next step is to create a python script which exposes the problem, an
 example is the following.
 
 .. code-block:: python
@@ -72,7 +72,7 @@ example is the following.
     from zeep import Client
     from zeep.transports import Transport
 
-    # Replace YOUR-WSDL and OPERATION_NAME with the wsdl url 
+    # Replace YOUR-WSDL and OPERATION_NAME with the wsdl url
     # and the method name you are calling. The response
     # needs to be set in the content=""" """ var.
 

src/zeep/client.py

@@ -2,10 +2,9 @@
 import logging
 from contextlib import contextmanager
 
-from zeep.xsd.const import NotSet
 from zeep.transports import Transport
 from zeep.wsdl import Document
-
+from zeep.xsd.const import NotSet
 
 logger = logging.getLogger(__name__)
 
@@ -215,19 +214,14 @@ def create_service(self, binding_name, address):
                 "are: %s" % (', '.join(self.wsdl.bindings.keys())))
         return ServiceProxy(self, binding, address=address)
 
-    def create_message(self, operation, service_name=None, port_name=None,
-                       args=None, kwargs=None):
+    def create_message(self, service, operation_name, *args, **kwargs):
         """Create the payload for the given operation.
 
         :rtype: lxml.etree._Element
 
         """
-        service = self._get_service(service_name)
-        port = self._get_port(service, port_name)
-
-        args = args or tuple()
-        kwargs = kwargs or {}
-        envelope, http_headers = port.binding._create(operation, args, kwargs)
+        envelope, http_headers = service._binding._create(
+            operation_name, args, kwargs)
         return envelope
 
     def type_factory(self, namespace):