fix raven.utils.json.dumps exception

Author: cenkalti

raven/utils/json.py

@@ -35,7 +35,10 @@ def default(self, obj):
             try:
                 return super(BetterJSONEncoder, self).default(obj)
             except TypeError:
-                return repr(obj)
+                try:
+                    return repr(obj)
+                except Exception:
+                    return object.__repr__(obj)
         return encoder(obj)
 
 

tests/utils/json/tests.py

@@ -34,6 +34,17 @@ def __repr__(self):
         obj = Unknown()
         assert json.dumps(obj) == '"Unknown object"'
 
+    def test_unknown_type_with_repr_error(self):
+
+        class Unknown(object):
+            def __repr__(self):
+                raise Exception
+
+        obj = Unknown()
+        s = json.dumps(obj)
+        assert isinstance(s, str)
+        assert 'Unknown object at 0x' in s
+
     def test_decimal(self):
         d = {'decimal': Decimal('123.45')}
         assert json.dumps(d) == '{"decimal": "Decimal(\'123.45\')"}'