Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music does not allow for songs that have a loop after the beginning #4

Open
joncloud opened this issue Mar 11, 2023 · 0 comments
Open
Labels
bug Something isn't working _g1.exe Related to _g1.exe _g2.exe Related to _g2.exe _g3.exe Related to _g3.exe

Comments

@joncloud
Copy link
Owner

Expected Behavior

Songs should loop at whatever offset is defined in the song file.

Actual Behavior

When a song has defined a loop offset that isn't the same as the beginning of the song, there is a leak where MU_DataLeft in mu_man.c doesn't account for the bytes that are skipped by the offset.

Steps to Reproduce the Problem

This is a theoretical bug, because all of the songs included in GOTRES.DAT all loop at the start of the song.

Specifications

  • Version:
  • Platform:
  • Subsystem:
@joncloud joncloud added bug Something isn't working _g1.exe Related to _g1.exe _g2.exe Related to _g2.exe _g3.exe Related to _g3.exe labels Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _g1.exe Related to _g1.exe _g2.exe Related to _g2.exe _g3.exe Related to _g3.exe
Projects
None yet
Development

No branches or pull requests

1 participant