deprecate estargz (google#1660)

* deprecate estargz

* also deprecate crane optimize

* just delete 'crane optimize' and crane.Optimize

Author: imjasonh

README.md

@@ -36,7 +36,7 @@ Over time, we will add new functionality under experimental environment variable
 
 | Env Var | Value(s) | What is does |
 |---------|----------|--------------|
-| `GGCR_EXPERIMENT_ESTARGZ` | `"1"` | When enabled this experiment will direct `tarball.LayerFromOpener` to emit [estargz](https://github.com/opencontainers/image-spec/issues/815) compatible layers, which enable them to be lazily loaded by an appropriately configured containerd. |
+| `GGCR_EXPERIMENT_ESTARGZ` | `"1"` | ⚠️DEPRECATED⚠️: When enabled this experiment will direct `tarball.LayerFromOpener` to emit [estargz](https://github.com/opencontainers/image-spec/issues/815) compatible layers, which enable them to be lazily loaded by an appropriately configured containerd. |
 
 
 ### `v1.Image`

cmd/crane/cmd/optimize.go

@@ -123,7 +123,6 @@ func New(use, short string, options []crane.Option) *cobra.Command {
 		NewCmdList(&options),
 		NewCmdManifest(&options),
 		NewCmdMutate(&options),
-		NewCmdOptimize(&options),
 		NewCmdPull(&options),
 		NewCmdPush(&options),
 		NewCmdRebase(&options),

cmd/crane/cmd/root.go

@@ -549,9 +549,6 @@ func TestBadInputs(t *testing.T) {
 		{"Tag(invalid, invalid)", crane.Tag(invalid, invalid)},
 		{"Tag(404, invalid)", crane.Tag(valid404, invalid)},
 		{"Tag(404, 404)", crane.Tag(valid404, valid404)},
-		{"Optimize(invalid, invalid)", crane.Optimize(invalid, invalid, []string{})},
-		{"Optimize(404, invalid)", crane.Optimize(valid404, invalid, []string{})},
-		{"Optimize(404, 404)", crane.Optimize(valid404, valid404, []string{})},
 		// These return multiple values, which are hard to use as expressions.
 		{"Pull(invalid)", e(crane.Pull(invalid))},
 		{"Digest(invalid)", e(crane.Digest(invalid))},