-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed various components size / dimensions to some ratio of screen size #2
base: master
Are you sure you want to change the base?
Changed various components size / dimensions to some ratio of screen size #2
Conversation
…size (in pixels) of device, to create a more responsive GUI
Hey, @DarthFloopy |
Hmm... this looks good, but it's still too big on my 1080p screen. Can you try shrinking things a bit more? You might try allowing things to change sizes, instead of setting the min and max sizes to the same value. Also, please remove the new border on the reset button. (" Thanks! (BTW this repo has the "hacktoberfest" label, so you're good to go.) |
Okay, I'll remove the border and make the size a bit smaller. How small do you want it to be on a 1080p screen? 80% of screen or lesser? |
Yes, that's good. It would be nice if the buttons were small enough so they don't cover the reset button, and the window were easily shrinking down to 50% width and height. |
I switched to Grid Layout to make sure
For some reason the Panels are getting stacked vertically rather than horizontally and I can't seem to get them in horizontal orientation.
I was talking about adding |
Thanks! I like the grid layout. I think the reset button / middle section gets a bit too big though, so can we keep the
Also, I'd like to keep the two time readouts horizontal. (BTW, you just needed to swap your GridLayout constructor args.) I re-read the Hacktoberfest rules and labeled this PR as |
In GridLayout the button is expanding to occupy available space similar behavior can be seen in BordreLayout as we are setting button position as BorderLayout.CENTER. Thus, we need rigidArea. I'll add rigidArea back in again. So, all it would change is less code and same layout as it was previously + using screen pixel size to set the frame size of application.
My bad :D I swapped them in my head.
It shows 3/4 PRs in my profile. So I don't think it is counting this one. But all the other 3 PRs are merged so maybe that's why idk. Doesn't matter now. I started very late, also this was my first Hacktober. |
Sorry if this hasn't ended up going anywhere. Do you still want to work on this? (If not, I totally understand.) |
Everyone device has different amount of pixels in screen and hence setting dimensions of components in terms of screen size should help make the GUI more responsive and make the UX more uniform across devices.
Issue: #1