-
Notifications
You must be signed in to change notification settings - Fork 2
Can't get it to work with the built-in SCM input #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Okay, cheking:
|
I'm going to need some time to dig into this. Globally installed commitlint on Windows is a bit of a blind spot and I don't have a good test environment for it handy. You can probably work around the issue by installing any plugins locally in your project (and/or tweaking some config settings), but I understand that's not appealing for non-npm projects. |
installing locally on project solves the issue, but the possibility to have it global would be nice! additionally the commitlint site linked on the requirements of the project now instructs to install commitlint globally (see here), but their repo readme instructs to install locally to dev, maybe it changed in the way but as I followed the linked one I had this problem |
When loading a local instance of `@commitlint/load`, use its path as the `PREFIX` when attempting to actually load a configuration. This should improve the chances that any installed configurations or plugins are discovered by preferring the location of a previously discovered library rather over a more generic global location. Fixes #600 Fixes #744
I think I got this working and published 2.4.3 with a fix. Let me know if it's still misbehaving for you. Thanks for the help reproducing the issue! |
I reverted the fix for this to fix #750--on review, my initial attempt was ill-conceived and effectively just undid the work that was done to improve compatibility with global installations for #491. Short term, v2.4.6 is the latest version with this behavior, so if that works for you, feel free to stay on that version. Longer term, I think the fix here might involve trying to load configs multiple times (e.g., with or without |
#744 (comment) says that installing locally may work and #744 (comment) says that it does work, but I can't get diagnostics to show. I use the Commit button with a blank message to get the full editor COMMIT_EDITMSG view. When I type there is no diagnostic to help. I have this installed locally...
I've installed the extension,
Any suggestion as to what I could be missing? |
@jibbers42 What you've shared seems okay to me. If you could answer the questions from #744 (comment) it could help narrow things down a bit more. (For instance, the |
…mically importing them Fixes joshbolduc#744, but opens the path to previously inaccessible bugs e.g. ``` RangeError: Found rules without implementation: extends. Supported rules are: body-case, body-empty, body-full-stop, body-leading-blank, body-max-length, body-max-line-length, body-min-length, footer-empty, footer-leading-blank, footer-max-length, footer-max-line-length, footer-min-length, header-case, header-full-stop, header-max-length, header-min-length, header-trim, references-empty, scope-case, scope-empty, scope-enum, scope-max-length, scope-min-length, signed-off-by, subject-case, subject-empty, subject-full-stop, subject-max-length, subject-min-length, subject-exclamation-mark, trailer-exists, type-case, type-empty, type-enum, type-max-length, type-min-length. at lint (file:///c:/Repos/HaloSPV3/hce.shared-config/node_modules/@commitlint/lint/lib/lint.js:48:15) at async lint (c:\Repos\BinToss\joshbulduc.vscode-commitlint\dist\worker\index.js:213:22) at async handleAsync (c:\Repos\BinToss\joshbulduc.vscode-commitlint\dist\worker\index.js:238:22) ```
I fixed it. It's the ol' Formatting the module path(s) with After writing a fix for it (and later fixing the bad config), the extension now works in both the full editor and the Git side panel on Windows |
…mically importing them (#792) Fixes #744, but opens the path to previously inaccessible bugs e.g. ``` RangeError: Found rules without implementation: extends. Supported rules are: body-case, body-empty, body-full-stop, body-leading-blank, body-max-length, body-max-line-length, body-min-length, footer-empty, footer-leading-blank, footer-max-length, footer-max-line-length, footer-min-length, header-case, header-full-stop, header-max-length, header-min-length, header-trim, references-empty, scope-case, scope-empty, scope-enum, scope-max-length, scope-min-length, signed-off-by, subject-case, subject-empty, subject-full-stop, subject-max-length, subject-min-length, subject-exclamation-mark, trailer-exists, type-case, type-empty, type-enum, type-max-length, type-min-length. at lint (file:///c:/Repos/HaloSPV3/hce.shared-config/node_modules/@commitlint/lint/lib/lint.js:48:15) at async lint (c:\Repos\BinToss\joshbulduc.vscode-commitlint\dist\worker\index.js:213:22) at async handleAsync (c:\Repos\BinToss\joshbulduc.vscode-commitlint\dist\worker\index.js:238:22) ``` --------- Co-authored-by: Josh Bolduc <[email protected]>
List of things I have done:
on the last step nothing happened and the invalid message was commited with no warnings.
Is there something I'm missing?
The text was updated successfully, but these errors were encountered: