Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Rack compatible HttpRouter#call takes a block #34

Open
ghost opened this issue Sep 29, 2013 · 2 comments
Open

[Q] Rack compatible HttpRouter#call takes a block #34

ghost opened this issue Sep 29, 2013 · 2 comments

Comments

@ghost
Copy link

ghost commented Sep 29, 2013

... but I'm unable to follow the code to where its used (or why its there). recognize seems to do the same as well.

In both cases, when a block is passed, the call ends up returning a HttpRouter::Request instead (which is not a valid rack response).

Any help on this would be appreciated. I'd be willing to help patch this if needed (if this is not intended behavior). Of course, its likely that I'm just missing something.

@ghost
Copy link
Author

ghost commented Sep 29, 2013

tagging @joshbuddy

@ghost
Copy link
Author

ghost commented Sep 29, 2013

also, the docs mention that the #call method can take both env or ``Rack::Request`. In my code, I've found the latter to not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants