-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role problem! #5
Open
ghost
wants to merge
97
commits into
joshlevinson:master
Choose a base branch
from
strangerstudios:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deactivate with a bit more cleanup. Users are given the "Subscriber" role if they had a membership level based role before.
Bug Fix: Deactivate and delete roles plugin action link would still show after clicking this link to deactivate the plugin. Only show this if the plugin is activated.
Enhancement: Assign default capabilities to custom pmpro_roles.
BUG FIX: delete roles and deactivate fix.
Enhancement: Assign default capabilities
Updating readme and plugin main file.
Updating release date
…rly updated on license server)
Updating to version 1.2
Removes administrator role from the list using a filter instead
Adds multiple roles to level settings
- Creates a role when creating a new level - Bug fixed where roles weren't assigned when not using MMPU - Update level updates role name if needed
Removed some commented out debugging code. Adjusted the function name update_role to update_role_name to be more explicit.
ENHANCEMENT: If only one role is selected, replace the default role with that role. If more than one is selected, give multiple roles.
ENHANCEMENT: Enabled localization and escaping of strings on the front-end. BUG FIX: Fixed an issue where selecting delete and deactivate will set user's to subscriber even if multiple roles were selected. This now only removes the pmpro_role_x if the user has more than one role assigned at the time of deactivation. ENHANCEMENT: Added docblocks to all methods. BUG FIX/ENHANCEMENT: Cleaned up the delete level method. (Refactored).
Updated MD file.
Replace roles instead of adding to them
Adjusting to use the core PMPro clickable and scroll box selectors.
Fixes critical error when PMPro is inactive
* Loading the class on plugins_loaded to prevent fatal error if PMPro is deactivated.
Selectors update array method; special UI for level-specific role
… hooks and not others. * Fix an issue when PMPro isn't activated some default WP hooks weren't loading (while roles was active).
…-change Default role removal after level change
* Updated: default to site role if no role is selected.
Fix undefined array key
Adding column 'role' to members list
* BUG FIX: Fixed an issue where in some cases the draft_role is created but not removed. Now it is removed whenever you "Delete and deactivate" on the plugins installation page.
Default to site default role
Remove the draft role on plugin deletion
* Includes adjustments to WPCS, and various security (minor) improvements .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello joshlevinson!
Thanks for your pmpro roles plugin.
My WordPress site has a user role set up and has many more users using these roles.
When I install the paid memberships pro and pmpro roles plugin, I want it to be able to select one or more of the existing user roles to match the paid Memberships pro membership level, not just add a new one. Is it possible to add this functionality to the next update to the pmpro roles plugin?
I am looking forward to, I believe that there will be more people like your updated version.
thank you!