Merge pull request #25 from f4lco/alignment

Discuss: alignment of fixed fields

Author: joutvhu

build.gradle

@@ -44,6 +44,7 @@ dependencies {
 
     testImplementation 'junit:junit:4.13'
     testImplementation 'org.junit.jupiter:junit-jupiter-api:5.6.2'
+    testImplementation 'org.junit.jupiter:junit-jupiter-params:5.6.2'
     testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.6.2'
     testRuntimeOnly 'org.junit.vintage:junit-vintage-engine:5.6.2'
 

src/test/java/com/joutvhu/fixedwidth/parser/AlignmentTests.java

@@ -0,0 +1,93 @@
+package com.joutvhu.fixedwidth.parser;
+
+import com.joutvhu.fixedwidth.parser.annotation.FixedField;
+import com.joutvhu.fixedwidth.parser.annotation.FixedObject;
+import com.joutvhu.fixedwidth.parser.domain.Alignment;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+class AlignmentTests {
+
+    private FixedParser fixedParser;
+
+    @BeforeAll
+    public void beforeTest() {
+        this.fixedParser = FixedParser.parser();
+    }
+
+    @ParameterizedTest
+    @MethodSource("samples")
+    void validateFormattedFieldWithPadding(Sample sample) {
+        String output = fixedParser.export(sample.person);
+
+        assertEquals(sample.expected, output);
+    }
+
+    @SuppressWarnings("unused")
+    static List<Sample> samples() {
+        return Arrays.asList(
+                new Sample(new AutoPerson("Bob"), "Bob       "),
+
+                // FIXME "left" alignment means padding to the right to me
+                new Sample(new LeftPerson("Bob"), "Bob       "),
+
+                // FIXME "right" alignment means padding to the left for me
+                new Sample(new RightPerson("Bob"), "       Bob"),
+
+                new Sample(new CenterPerson("Bob"), "   Bob    "),
+
+                // FIXME fixed length = 10, "Emma".length = 4, this means 3 chars to the left, and 3 chars to the right
+                // But the padding routine constructs a string of length 11, 4 spaces to the left, 3 spaces to the right
+                new Sample(new CenterPerson("Emma"), "   Emma   ")
+        );
+    }
+
+    @Data
+    @AllArgsConstructor
+    static class Sample {
+        private Object person;
+        private String expected;
+    }
+
+    @FixedObject
+    @Data
+    @AllArgsConstructor
+    public static class AutoPerson {
+        @FixedField(length = 10, alignment = Alignment.AUTO)
+        private String name;
+    }
+
+    @FixedObject
+    @Data
+    @AllArgsConstructor
+    public static class LeftPerson {
+        @FixedField(length = 10, alignment = Alignment.LEFT)
+        private String name;
+    }
+
+    @FixedObject
+    @Data
+    @AllArgsConstructor
+    public static class RightPerson {
+        @FixedField(length = 10, alignment = Alignment.RIGHT)
+        private String name;
+    }
+
+    @FixedObject
+    @Data
+    @AllArgsConstructor
+    public static class CenterPerson {
+        @FixedField(length = 10, alignment = Alignment.CENTER)
+        private String name;
+    }
+}