Skip to content

Commit 99250fe

Browse files
committed
Build: Drop support for Node 10
Ref gh-2249
1 parent fb19b03 commit 99250fe

File tree

2 files changed

+3
-46
lines changed

2 files changed

+3
-46
lines changed

.github/workflows/node.js.yml

-28
Original file line numberDiff line numberDiff line change
@@ -133,31 +133,3 @@ jobs:
133133

134134
- name: Test
135135
run: npm run test:unit -- -b safari --jquery ${{ matrix.JQUERY }} --retries 3
136-
137-
legacy-build:
138-
runs-on: ubuntu-latest
139-
name: Build on Node 10.x
140-
env:
141-
NODE_VERSION: 10.x
142-
steps:
143-
- name: Checkout
144-
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
145-
146-
- name: Use Node.js ${{ env.NODE_VERSION }}
147-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
148-
with:
149-
node-version: ${{ env.NODE_VERSION }}
150-
151-
- name: Cache
152-
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
153-
with:
154-
path: ~/.npm
155-
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-${{ hashFiles('**/package-lock.json') }}
156-
restore-keys: |
157-
${{ runner.os }}-node-${{ env.NODE_VERSION }}-npm-lock-
158-
159-
- name: Install npm dependencies
160-
run: npm install
161-
162-
- name: Build
163-
run: npm run build

Gruntfile.js

+3-18
Original file line numberDiff line numberDiff line change
@@ -84,15 +84,6 @@ const htmllintBad = [
8484
"tests/unit/tabs/data/test.html"
8585
];
8686

87-
const nodeV16OrNewer = !/^v1[0-5]\./.test( process.version );
88-
89-
// Support: Node.js <16
90-
// Skip running tasks that dropped support for Node.js 10-15
91-
// in this Node version.
92-
function runIfNewNode( task ) {
93-
return nodeV16OrNewer ? task : "print_old_node_message:" + task;
94-
}
95-
9687
function mapMinFile( file ) {
9788
return "dist/" + file.replace( /ui\//, "minified/" );
9889
}
@@ -357,13 +348,7 @@ grunt.initConfig( {
357348
} );
358349

359350
// grunt plugins
360-
require( "load-grunt-tasks" )( grunt, {
361-
pattern: nodeV16OrNewer ? [ "grunt-*" ] : [
362-
"grunt-*",
363-
"!grunt-eslint",
364-
"!grunt-html"
365-
]
366-
} );
351+
require( "load-grunt-tasks" )( grunt );
367352

368353
// local tasks
369354
grunt.loadTasks( "build/tasks" );
@@ -406,9 +391,9 @@ grunt.registerTask( "print_old_node_message", ( ...args ) => {
406391
// Keep this task list in sync with the testing steps in our GitHub action test workflow file!
407392
grunt.registerTask( "lint", [
408393
"asciilint",
409-
runIfNewNode( "eslint" ),
394+
"eslint",
410395
"csslint",
411-
runIfNewNode( "htmllint" )
396+
"htmllint"
412397
] );
413398
grunt.registerTask( "build", [ "requirejs", "concat" ] );
414399
grunt.registerTask( "default", [ "lint", "build" ] );

0 commit comments

Comments
 (0)