Skip to content

Commit 8ba892b

Browse files
committed
dropdownItemLabel promoted into scope variable
For dropdownSelect and dropdownMenu the dropdownItemLabel is not taken from the isolate scope variable rether than attrs to make the $interpolation of the value possible.
1 parent 6686869 commit 8ba892b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

angular-dropdowns.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ dd.directive('dropdownSelect', ['DropdownService',
6868
scope: {
6969
dropdownSelect: '=',
7070
dropdownModel: '=',
71+
dropdownItemLabel: '@',
7172
dropdownOnchange: '&'
7273
},
7374

7475
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
75-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
76+
$scope.labelField = $scope.dropdownItemLabel || 'text';
7677

7778
DropdownService.register($element);
7879

@@ -131,11 +132,12 @@ dd.directive('dropdownMenu', ['$parse', '$compile', 'DropdownService', '$templat
131132
scope: {
132133
dropdownMenu: '=',
133134
dropdownModel: '=',
135+
dropdownItemLabel: '@',
134136
dropdownOnchange: '&'
135137
},
136138

137139
controller: ['$scope', '$element', '$attrs', function ($scope, $element, $attrs) {
138-
$scope.labelField = $attrs.dropdownItemLabel || 'text';
140+
$scope.labelField = $scope.dropdownItemLabel || 'text';
139141

140142
var $template = angular.element($templateCache.get('ngDropdowns/templates/dropdownMenu.html'));
141143
// Attach this controller to the element's data
@@ -233,4 +235,4 @@ dd.factory('DropdownService', ['$document',
233235
return service;
234236
}
235237
]);
236-
})(window, window.angular);
238+
})(window, window.angular);

0 commit comments

Comments
 (0)