Skip to content

Commit f17783b

Browse files
Yonsh Linwkh237
Yonsh Lin
authored andcommitted
Fix some Promise.reject not being returned in FileSystem (wkh237#366)
1 parent 680331d commit f17783b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

fs.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,12 @@ function writeFile(path:string, data:string | Array<number>, encoding:?string):P
171171
return Promise.reject('Invalid argument "path" ')
172172
if(encoding.toLocaleLowerCase() === 'ascii') {
173173
if(!Array.isArray(data))
174-
Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
174+
return Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
175175
else
176176
return RNFetchBlob.writeFileArray(path, data, false);
177177
} else {
178178
if(typeof data !== 'string')
179-
Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
179+
return Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
180180
else
181181
return RNFetchBlob.writeFile(path, encoding, data, false);
182182
}
@@ -188,12 +188,12 @@ function appendFile(path:string, data:string | Array<number>, encoding:?string):
188188
return Promise.reject('Invalid argument "path" ')
189189
if(encoding.toLocaleLowerCase() === 'ascii') {
190190
if(!Array.isArray(data))
191-
Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
191+
return Promise.reject(new Error(`Expected "data" is an Array when encoding is "ascii", however got ${typeof data}`))
192192
else
193193
return RNFetchBlob.writeFileArray(path, data, true);
194194
} else {
195195
if(typeof data !== 'string')
196-
Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
196+
return Promise.reject(new Error(`Expected "data" is a String when encoding is "utf8" or "base64", however got ${typeof data}`))
197197
else
198198
return RNFetchBlob.writeFile(path, encoding, data, true);
199199
}

0 commit comments

Comments
 (0)