From f247a1955e53dcd4d87de75751ef3e9a144e305a Mon Sep 17 00:00:00 2001 From: Jean-Michel FRANCOIS Date: Mon, 11 Dec 2017 16:05:57 +0100 Subject: [PATCH 1/2] fix(canonical-title-map): add use case for enumNames --- src/lib/canonical-title-map.js | 11 +++++++++++ src/lib/canonical-title-map.spec.js | 11 ++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/lib/canonical-title-map.js b/src/lib/canonical-title-map.js index 1720eaf..0749ae0 100644 --- a/src/lib/canonical-title-map.js +++ b/src/lib/canonical-title-map.js @@ -14,6 +14,17 @@ export default function(titleMap: Array, originalEnum?: any) { }); } return canonical; + } else if (originalEnum) { + const canonical = []; + return originalEnum.map((value, index) => { + if (typeof titleMap[index] === 'string') { + return { + name: titleMap[index], + value, + } + } + return titleMap[index]; + }); } return titleMap; } diff --git a/src/lib/canonical-title-map.spec.js b/src/lib/canonical-title-map.spec.js index 11c4430..16b1659 100644 --- a/src/lib/canonical-title-map.spec.js +++ b/src/lib/canonical-title-map.spec.js @@ -36,6 +36,15 @@ describe('canonical-title-map.js', () => { result.should.be.deep.equal(titlemap); }); + it('should return a titleMap for a enumNames list with enum values', () => { + let result = canonicalTitleMap([ 'name', 'firstname', 'phone' ], [ 'n', 'f', 'p' ]); + result.should.be.deep.equal([ + { name: 'name', value: 'n' }, + { name: 'firstname', value: 'f' }, + { name: 'phone', value: 'p' }, + ]); + }); + it('should return a titleMap for a titleMap object without enum', () => { let result = canonicalTitleMap(titlemapObj); result.should.be.deep.equal(titlemap); @@ -56,4 +65,4 @@ describe('canonical-title-map.js', () => { result.should.be.deep.equal(titlemap); }); }); -}); +}); \ No newline at end of file From 4a6cb497ae47d90fa8b3450762b6406857a5c611 Mon Sep 17 00:00:00 2001 From: Jean-Michel FRANCOIS Date: Mon, 11 Dec 2017 20:47:48 +0100 Subject: [PATCH 2/2] fix: add EOL --- src/lib/canonical-title-map.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/canonical-title-map.spec.js b/src/lib/canonical-title-map.spec.js index 16b1659..4fdac0d 100644 --- a/src/lib/canonical-title-map.spec.js +++ b/src/lib/canonical-title-map.spec.js @@ -65,4 +65,4 @@ describe('canonical-title-map.js', () => { result.should.be.deep.equal(titlemap); }); }); -}); \ No newline at end of file +});