Skip to content

Commit e4bceb1

Browse files
committed
Bump the python-jsonschema version used for the sanity check.
The test in this PR (#664) actually trips a bug in the older version (where it doesn't properly consider the keys in definitions to not be schemas, they're just labels)
1 parent 1008edc commit e4bceb1

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

bin/jsonschema_suite

+14
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,13 @@ class SanityTests(unittest.TestCase):
498498
"title",
499499
"type",
500500
"uniqueItems",
501+
502+
# Technically this is wrong, $comment doesn't exist in this
503+
# draft, but the point of this test is to detect mistakes by,
504+
# test authors, whereas the point of the $comment keyword is
505+
# to just standardize a place for a comment, so it's not a
506+
# mistake to use it in earlier drafts in tests per se.
507+
"$comment",
501508
},
502509
"draft3": {
503510
"$ref",
@@ -528,6 +535,13 @@ class SanityTests(unittest.TestCase):
528535
"title",
529536
"type",
530537
"uniqueItems",
538+
539+
# Technically this is wrong, $comment doesn't exist in this
540+
# draft, but the point of this test is to detect mistakes by,
541+
# test authors, whereas the point of the $comment keyword is
542+
# to just standardize a place for a comment, so it's not a
543+
# mistake to use it in earlier drafts in tests per se.
544+
"$comment",
531545
},
532546
}
533547

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ skipsdist = True
55

66
[testenv:sanity]
77
# used just for validating the structure of the test case files themselves
8-
deps = jsonschema==4.17.3
8+
deps = jsonschema==4.18.0a4
99
commands = {envpython} bin/jsonschema_suite check

0 commit comments

Comments
 (0)