From e5758c8a9bedac2e4d2bf52e921671fd15f9cea2 Mon Sep 17 00:00:00 2001 From: jstet Date: Sat, 3 Aug 2024 17:36:48 +0200 Subject: [PATCH] update README and fix validation --- README.md | 14 ++++++++++++-- src/lib/data/organizations/de/giz_data_lab.json | 2 +- src/lib/data/organizations/mex/prosperia.json | 2 +- .../organizations/us/development_data_lab.json | 2 +- src/lib/parsing/validation.js | 1 - 5 files changed, 15 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index a0de38b..f715c17 100644 --- a/README.md +++ b/README.md @@ -26,15 +26,25 @@ The motivation behind this project is to provide an overview of organizations th The content of data4good.work is managed with static files that are part of the folder `src/lib/data/organizations`. +### Edit Organization + +1. To edit an organizations, first complete the dev setup described above and depending on your access rights fork this repo or create a branch. + +2. Then go to the corresponding foler and make the change. + +3. After making your changes, test them with `npm run dev` and open a PR that one of the admins will review and merge. + +### Add Organization + 1. To add organizations, first complete the dev setup described above and depending on your access rights fork this repo or create a branch. -2. Then you can either add files manually, or run a script: +2. Then you can either add files manually (simply copy an exising file and adjust the values), or run a script that will prompt you to provide necessary data and create the file automatically: ``` node scripts/add_org.js ``` -3. After adding organizations, open a PR that one of the admins will review and merge. +3. After adding organizations, test your changes with `npm run dev` and open a PR that one of the admins will review and merge. diff --git a/src/lib/data/organizations/de/giz_data_lab.json b/src/lib/data/organizations/de/giz_data_lab.json index c6d3b93..483d7f9 100644 --- a/src/lib/data/organizations/de/giz_data_lab.json +++ b/src/lib/data/organizations/de/giz_data_lab.json @@ -9,7 +9,7 @@ "remote_possible": false, "initiative_application_possible": null, "type": { - "framework": "Governmental", + "framework": "Non-Profit", "emphasis": "Cause-Focused" }, "working_languages": ["de"] diff --git a/src/lib/data/organizations/mex/prosperia.json b/src/lib/data/organizations/mex/prosperia.json index 60e8e65..eeaa2ab 100644 --- a/src/lib/data/organizations/mex/prosperia.json +++ b/src/lib/data/organizations/mex/prosperia.json @@ -10,7 +10,7 @@ "initiative_application_possible": null, "type": { "framework": "For-Profit", - "emphasis": "Product Focused" + "emphasis": "Product-Focused" }, "working_languages": ["es"] } diff --git a/src/lib/data/organizations/us/development_data_lab.json b/src/lib/data/organizations/us/development_data_lab.json index 555f1e8..0c9d3a1 100644 --- a/src/lib/data/organizations/us/development_data_lab.json +++ b/src/lib/data/organizations/us/development_data_lab.json @@ -11,7 +11,7 @@ "initiative_application_possible": null, "type": { "framework": "Non-Profit", - "emphasis": "Cause Focused" + "emphasis": "Cause-Focused" } } \ No newline at end of file diff --git a/src/lib/parsing/validation.js b/src/lib/parsing/validation.js index fe46ac4..40c6e32 100644 --- a/src/lib/parsing/validation.js +++ b/src/lib/parsing/validation.js @@ -27,7 +27,6 @@ export const validateLanguage = (value) => { return 'Must be 2 characters'; } try { - console.log(validateLanguageCode(value), value); validateLanguageCode(value); return true; } catch (e) {