Skip to content

Commit 8624343

Browse files
committed
Merge pull request #69 from burnnat/fix-jsx-props
Only mark component types as used, not prop names.
2 parents 3e2e92d + 3fc121b commit 8624343

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

lib/rules/jsx-uses-vars.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ module.exports = function(context) {
2020
variableUtil.markVariableAsUsed(context, node.expression.name);
2121
},
2222

23-
JSXIdentifier: function(node) {
24-
variableUtil.markVariableAsUsed(context, node.name);
23+
JSXOpeningElement: function(node) {
24+
variableUtil.markVariableAsUsed(context, node.name.name);
2525
}
2626

2727
};

tests/lib/rules/jsx-uses-vars.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,18 @@ eslintTester.addRuleTest('node_modules/eslint/lib/rules/no-unused-vars', {
6565
invalid: [
6666
{
6767
code: '/*eslint jsx-uses-vars:1*/ var App;',
68-
errors: [{message: 'App is defined but never used'}], ecmaFeatures: {jsx: true}
68+
errors: [{message: 'App is defined but never used'}],
69+
ecmaFeatures: {jsx: true}
70+
}, {
71+
code: '\
72+
/*eslint jsx-uses-vars:1*/\
73+
var App;\
74+
var unused;\
75+
React.render(<App unused=""/>);',
76+
errors: [{message: 'unused is defined but never used'}],
77+
ecmaFeatures: {
78+
jsx: true
79+
}
6980
}
7081
]
7182
});

0 commit comments

Comments
 (0)