Skip to content

Commit 89dcdf6

Browse files
committed
Only check object direct properties when computing the methods order (fixes #88)
1 parent 8f1acfc commit 89dcdf6

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

lib/rules/sort-comp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function getMethodsOrder(defaultConfig, userConfig) {
2525
var entry;
2626
for (var i = 0, j = order.length; i < j; i++) {
2727
entry = order[i];
28-
if (groups[entry]) {
28+
if (groups.hasOwnProperty(entry)) {
2929
config = config.concat(groups[entry]);
3030
} else {
3131
config.push(entry);

tests/lib/rules/sort-comp.js

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,29 @@ eslintTester.addRuleTest('lib/rules/sort-comp', {
166166
classes: true,
167167
jsx: true
168168
}
169+
}, {
170+
// Must allow us to use 'constructor' as a method name
171+
code: [
172+
'class Hello extends React.Component {',
173+
' constructor() {}',
174+
' displayName() {}',
175+
' render() {',
176+
' return <div>Hello</div>;',
177+
' }',
178+
'}'
179+
].join('\n'),
180+
args: [1, {
181+
order: [
182+
'constructor',
183+
'lifecycle',
184+
'everything-else',
185+
'render'
186+
]
187+
}],
188+
ecmaFeatures: {
189+
classes: true,
190+
jsx: true
191+
}
169192
}],
170193

171194
invalid: [{

0 commit comments

Comments
 (0)