Skip to content

Commit d46df39

Browse files
committed
fixup! fixup! feat(jsx-key): check for array related method calls with jsx elements/fragments
1 parent 10cdb5e commit d46df39

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

lib/rules/jsx-key.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -264,17 +264,14 @@ module.exports = {
264264
},
265265

266266
// eslint-disable-next-line no-multi-str
267-
'CallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
268-
CallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
269-
OptionalCallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
270-
OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with$/]'(node) {
271-
if (node.arguments.length === 0) {
272-
return;
273-
}
274-
267+
'CallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with|concat$/],\
268+
CallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with|concat$/],\
269+
OptionalCallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with|concat$/],\
270+
OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with|concat$/]'(node) {
275271
node.arguments.forEach((arg) => {
276272
if (arg.type === 'JSXElement' && !hasProp(arg.openingElement.attributes, 'key')) {
277273
report(context, messages.missingIterKey, 'missingArrayKey', { node });
274+
return;
278275
}
279276
if (arg.type === 'JSXFragment') {
280277
report(context, messages.missingIterKey, 'missingArrayKeyUsePrag', { node });

0 commit comments

Comments
 (0)