Skip to content

Commit eede741

Browse files
committed
Fix jsx-sort-prop-types issue with custom propTypes
1 parent d7c3ad2 commit eede741

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

lib/rules/jsx-sort-prop-types.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ module.exports = function(context) {
4040
}
4141

4242
function getValueName(node) {
43-
return node.value.property.name;
43+
return node.value.property && node.value.property.name;
4444
}
4545

4646
function isCallbackPropName(propName) {

tests/lib/rules/jsx-sort-prop-types.js

+15
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,21 @@ ruleTester.run('jsx-sort-prop-types', rule, {
276276
requiredFirst: true
277277
}],
278278
parserOptions: parserOptions
279+
}, {
280+
code: [
281+
'class First extends React.Component {',
282+
' render() {',
283+
' return <div />;',
284+
' }',
285+
'}',
286+
'First.propTypes = {',
287+
' fooRequired: MyPropType,',
288+
'};'
289+
].join('\n'),
290+
options: [{
291+
requiredFirst: true
292+
}],
293+
parserOptions: parserOptions
279294
}, {
280295
code: [
281296
'class First extends React.Component {',

0 commit comments

Comments
 (0)