Skip to content

Commit 3c05f2f

Browse files
committed
Updated for Elasticsearch 0.90.6 - Pom file memory settings so it builds and passes. Corrected code for 0.90.6 and fixed issue where >1 thread was trying to write to the same file at the same time. Fixed ATs.
1 parent a3bb7f6 commit 3c05f2f

File tree

10 files changed

+14
-22
lines changed

10 files changed

+14
-22
lines changed

pom.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<url>https://github.com/crate/elasticsearch-inout-plugin</url>
1515
</scm>
1616
<properties>
17-
<elasticsearch.version>0.90.3</elasticsearch.version>
17+
<elasticsearch.version>0.90.6</elasticsearch.version>
1818
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1919
</properties>
2020
<build>
@@ -52,6 +52,7 @@
5252
<configuration>
5353
<source>1.6</source>
5454
<target>1.6</target>
55+
<argLine>-X2048m -XX:MaxDirectMemorySize=256m</argLine>
5556
</configuration>
5657
</plugin>
5758
</plugins>

src/main/java/crate/elasticsearch/action/export/AbstractTransportExportAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ protected ShardExportResponse shardOperation(ShardExportRequest request) throws
149149
SearchShardTarget shardTarget = new SearchShardTarget(clusterService.localNode().id(), request.index(), request.shardId());
150150
ExportContext context = new ExportContext(0,
151151
new ShardSearchRequest().types(request.types()).filteringAliases(request.filteringAliases()),
152-
shardTarget, indexShard.searcher(), indexService, indexShard, scriptService, cacheRecycler, nodePath);
152+
shardTarget, indexShard.acquireSearcher("export"), indexService, indexShard, scriptService, cacheRecycler, nodePath);
153153
ExportContext.setCurrent(context);
154154

155155
try {

src/main/java/crate/elasticsearch/action/export/ExportRequest.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.elasticsearch.action.ActionRequestValidationException;
44
import org.elasticsearch.action.support.broadcast.BroadcastOperationRequest;
55
import org.elasticsearch.common.Nullable;
6-
import org.elasticsearch.common.Required;
76
import org.elasticsearch.common.Strings;
87
import org.elasticsearch.common.bytes.BytesArray;
98
import org.elasticsearch.common.bytes.BytesReference;
@@ -59,14 +58,12 @@ protected void beforeStart() {
5958
public BytesReference source() {
6059
return source;
6160
}
62-
63-
@Required
61+
6462
public ExportRequest source(String source) {
6563
return this.source(new BytesArray(source), false);
6664
}
6765

6866

69-
@Required
7067
public ExportRequest source(BytesReference source, boolean unsafe) {
7168
this.source = source;
7269
this.querySourceUnsafe = unsafe;

src/main/java/crate/elasticsearch/action/import_/ImportRequest.java

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package crate.elasticsearch.action.import_;
22

33
import org.elasticsearch.action.support.nodes.NodesOperationRequest;
4-
import org.elasticsearch.common.Required;
54
import org.elasticsearch.common.bytes.BytesArray;
65
import org.elasticsearch.common.bytes.BytesReference;
76
import org.elasticsearch.common.io.stream.StreamInput;
@@ -32,12 +31,10 @@ public BytesReference source() {
3231
return source;
3332
}
3433

35-
@Required
3634
public ImportRequest source(String source) {
3735
return this.source(new BytesArray(source), false);
3836
}
3937

40-
@Required
4138
public ImportRequest source(BytesReference source, boolean unsafe) {
4239
this.source = source;
4340
return this;

src/main/java/crate/elasticsearch/action/searchinto/AbstractTransportSearchIntoAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ protected ShardSearchIntoResponse shardOperation(ShardSearchIntoRequest
168168
request.shardId());
169169
SearchIntoContext context = new SearchIntoContext(0,
170170
new ShardSearchRequest().types(request.types()).filteringAliases(request.filteringAliases()),
171-
shardTarget, indexShard.searcher(), indexService, indexShard, scriptService, cacheRecycler
171+
shardTarget, indexShard.acquireSearcher("export"), indexService, indexShard, scriptService, cacheRecycler
172172
);
173173
SearchIntoContext.setCurrent(context);
174174

src/main/java/crate/elasticsearch/action/searchinto/SearchIntoRequest.java

-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.elasticsearch.action.ActionRequestValidationException;
44
import org.elasticsearch.action.support.broadcast.BroadcastOperationRequest;
55
import org.elasticsearch.common.Nullable;
6-
import org.elasticsearch.common.Required;
76
import org.elasticsearch.common.Strings;
87
import org.elasticsearch.common.bytes.BytesArray;
98
import org.elasticsearch.common.bytes.BytesReference;
@@ -63,13 +62,11 @@ public BytesReference source() {
6362
return source;
6463
}
6564

66-
@Required
6765
public SearchIntoRequest source(String source) {
6866
return this.source(new BytesArray(source), false);
6967
}
7068

7169

72-
@Required
7370
public SearchIntoRequest source(BytesReference source, boolean unsafe) {
7471
this.source = source;
7572
this.querySourceUnsafe = unsafe;

src/main/java/crate/elasticsearch/export/Exporter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void check(ExportContext context) throws ExportException {
7575
}
7676
}
7777

78-
public Result execute(ExportContext context) {
78+
public synchronized Result execute(ExportContext context) {
7979
if (context.settings() || context.mappings()) {
8080
writeSettingsOrMappings(context);
8181
}

src/main/java/crate/elasticsearch/rest/action/admin/export/RestExportAction.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import static org.elasticsearch.rest.RestRequest.Method.POST;
44
import static org.elasticsearch.rest.RestStatus.BAD_REQUEST;
55
import static org.elasticsearch.rest.RestStatus.OK;
6-
import static org.elasticsearch.rest.action.support.RestActions.splitTypes;
6+
import org.elasticsearch.common.Strings;
77

88
import java.io.IOException;
99

@@ -52,7 +52,7 @@ protected Action<ExportRequest, ExportResponse, ExportRequestBuilder> action() {
5252
}
5353

5454
public void handleRequest(final RestRequest request, final RestChannel channel) {
55-
ExportRequest exportRequest = new ExportRequest(RestActions.splitIndices(request.param("index")));
55+
ExportRequest exportRequest = new ExportRequest(Strings.splitStringByCommaToArray(request.param("index")));
5656

5757
if (request.hasParam("ignore_indices")) {
5858
exportRequest.ignoreIndices(IgnoreIndices.fromString(request.param("ignore_indices")));
@@ -79,7 +79,7 @@ public void handleRequest(final RestRequest request, final RestChannel channel)
7979
}
8080
}
8181
exportRequest.routing(request.param("routing"));
82-
exportRequest.types(splitTypes(request.param("type")));
82+
exportRequest.types(Strings.splitStringByCommaToArray(request.param("type")));
8383
exportRequest.preference(request.param("preference", "_primary"));
8484
} catch (Exception e) {
8585
try {

src/main/java/crate/elasticsearch/rest/action/admin/searchinto/RestSearchIntoAction.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import static org.elasticsearch.rest.RestRequest.Method.POST;
44
import static org.elasticsearch.rest.RestStatus.BAD_REQUEST;
55
import static org.elasticsearch.rest.RestStatus.OK;
6-
import static org.elasticsearch.rest.action.support.RestActions.splitTypes;
7-
6+
/** import static org.elasticsearch.rest.action.support.RestActions; **/
7+
import org.elasticsearch.common.Strings;
88
import java.io.IOException;
99

1010
import org.elasticsearch.action.Action;
@@ -55,7 +55,7 @@ protected Action<SearchIntoRequest, SearchIntoResponse, SearchIntoRequestBuilder
5555
public void handleRequest(final RestRequest request,
5656
final RestChannel channel) {
5757
SearchIntoRequest searchIntoRequest = new SearchIntoRequest(
58-
RestActions.splitIndices(request.param("index")));
58+
Strings.splitStringByCommaToArray(request.param("index")));
5959

6060
if (request.hasParam("ignore_indices")) {
6161
searchIntoRequest.ignoreIndices(IgnoreIndices.fromString(
@@ -90,7 +90,7 @@ public void handleRequest(final RestRequest request,
9090
}
9191
}
9292
searchIntoRequest.routing(request.param("routing"));
93-
searchIntoRequest.types(splitTypes(request.param("type")));
93+
searchIntoRequest.types(Strings.splitStringByCommaToArray(request.param("type")));
9494
searchIntoRequest.preference(request.param("preference",
9595
"_primary"));
9696
} catch (Exception e) {

src/test/python/reindex.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ be closed first and then reopened::
5454
>>> post("/test/_close", {})
5555
{"ok":true,"acknowledged":true}
5656
>>> put("/test/_settings", {"analysis": {"analyzer": {"myan": {"type": "stop", "stopwords": ["nice"]}}}})
57-
{"ok":true}
57+
{"ok":true,"acknowledged":true}
5858
>>> post("/test/_open", {})
5959
{"ok":true,"acknowledged":true}
6060
>>> refresh()

0 commit comments

Comments
 (0)