Skip to content

Commit b55253d

Browse files
committed
Need to check the value for nil here.
1 parent d1dd97e commit b55253d

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

ngcplogger.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,14 +367,22 @@ func (l *nGCPLogger) extractMsgFromPayload(m map[string]any) {
367367

368368
func assertOrLog[T any](val any) T {
369369
var v T
370-
var ok bool
371-
v, ok = val.(T)
372-
if !ok {
370+
if val == nil {
373371
_, file, line, ok := runtime.Caller(1)
374372
if !ok {
375373
file = "unknown"
376374
}
377-
slog.Error("unexpected type", "want", reflect.TypeOf(v).String(), "got", reflect.TypeOf(val).String(), "file", file, "line", line)
375+
slog.Error("unexpected nil value", "file", file, "line", line)
376+
} else {
377+
var ok bool
378+
v, ok = val.(T)
379+
if !ok {
380+
_, file, line, ok := runtime.Caller(1)
381+
if !ok {
382+
file = "unknown"
383+
}
384+
slog.Error("unexpected type", "want", reflect.TypeOf(v).String(), "got", reflect.TypeOf(val).String(), "file", file, "line", line)
385+
}
378386
}
379387
return v
380388
}

0 commit comments

Comments
 (0)