Fix bug with negative time limits (#202)

Author: odow

Project.toml

@@ -1,7 +1,7 @@
 name = "GLPK"
 uuid = "60bf3e95-4087-53dc-ae20-288a0d20c6a6"
 repo = "https://github.com/jump-dev/GLPK.jl.git"
-version = "0.15.2"
+version = "0.15.3"
 
 [deps]
 BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232"

src/MOI_wrapper/MOI_wrapper.jl

@@ -353,7 +353,8 @@ end
 MOI.supports(::Optimizer, ::MOI.TimeLimitSec) = true
 
 _limit_sec_to_ms(::Nothing) = typemax(Int32)
-_limit_sec_to_ms(x::Real) = ceil(Int32, min(typemax(Int32), 1_000 * x))
+# Project the timelimit onto [0, typemax(Int32)] to avoid nasty segfaults.
+_limit_sec_to_ms(x::Real) = ceil(Int32, max(0, min(typemax(Int32), 1_000 * x)))
 
 function MOI.set(
     model::Optimizer,

test/MOI_wrapper.jl

@@ -464,6 +464,13 @@ function test_empty_problem_unbounded()
     return
 end
 
+function test_negative_timelimitsec()
+    model = GLPK.Optimizer()
+    MOI.set(model, MOI.TimeLimitSec(), -1.23)
+    @test MOI.get(model, MOI.TimeLimitSec()) == 0.0
+    return
+end
+
 end  # module
 
 TestMOIWrapper.runtests()