Remove VERSION checks for unsupported Julia versions (#3172)

Author: odow

src/Containers/SparseAxisArray.jl

@@ -288,29 +288,27 @@ function _getindex(
     return bc.f(_get_arg(bc.args, index)...)
 end
 
-@static if VERSION >= v"1.3"
-    # `broadcast_preserving_zero_d` calls `axes(A)` which calls `size(A)` which
-    # is not defined. When at least one argument is a `SparseAxisArray`, we can
-    # simply redirect `broadcast_preserving_zero_d` to `broadcast` since we know
-    # the result won't be zero dimensional.
-
-    # Called by `A * 2`
-    function Base.Broadcast.broadcast_preserving_zero_d(
-        f,
-        A::SparseAxisArray,
-        As...,
-    )
-        return broadcast(f, A, As...)
-    end
-    # Called by `2 * A`
-    function Base.Broadcast.broadcast_preserving_zero_d(
-        f,
-        x,
-        A::SparseAxisArray,
-        As...,
-    )
-        return broadcast(f, x, A, As...)
-    end
+# `broadcast_preserving_zero_d` calls `axes(A)` which calls `size(A)` which
+# is not defined. When at least one argument is a `SparseAxisArray`, we can
+# simply redirect `broadcast_preserving_zero_d` to `broadcast` since we know
+# the result won't be zero dimensional.
+
+# Called by `A * 2`
+function Base.Broadcast.broadcast_preserving_zero_d(
+    f,
+    A::SparseAxisArray,
+    As...,
+)
+    return broadcast(f, A, As...)
+end
+# Called by `2 * A`
+function Base.Broadcast.broadcast_preserving_zero_d(
+    f,
+    x,
+    A::SparseAxisArray,
+    As...,
+)
+    return broadcast(f, x, A, As...)
 end
 
 ########

test/test_constraint.jl

@@ -691,22 +691,24 @@ function test_extension_nonsensical_SDP_constraint(
             "for symmetric variable.",
         )
     end
-    # Hack to work around an annoying change in Julia expression printing.
-    index_set = VERSION < v"1.1" ? "i=1:2, j=1:2" : "i = 1:2, j = 1:2"
     @test_throws_strip(
-        _ErrorException("@variable(m, foo[$index_set] >= Y[i, j], PSD)"),
+        _ErrorException("@variable(m, foo[i = 1:2, j = 1:2] >= Y[i, j], PSD)"),
         @variable(m, foo[i = 1:2, j = 1:2] >= Y[i, j], PSD),
     )
     @test_throws_strip(
-        _ErrorException("@variable(m, foo[$index_set] <= Y[i, j], PSD)"),
+        _ErrorException("@variable(m, foo[i = 1:2, j = 1:2] <= Y[i, j], PSD)"),
         @variable(m, foo[i = 1:2, j = 1:2] <= Y[i, j], PSD),
     )
     @test_throws_strip(
-        _ErrorException("@variable(m, foo[$index_set] >= Y[i, j], Symmetric)"),
+        _ErrorException(
+            "@variable(m, foo[i = 1:2, j = 1:2] >= Y[i, j], Symmetric)",
+        ),
         @variable(m, foo[i = 1:2, j = 1:2] >= Y[i, j], Symmetric),
     )
     @test_throws_strip(
-        _ErrorException("@variable(m, foo[$index_set] <= Y[i, j], Symmetric)"),
+        _ErrorException(
+            "@variable(m, foo[i = 1:2, j = 1:2] <= Y[i, j], Symmetric)",
+        ),
         @variable(m, foo[i = 1:2, j = 1:2] <= Y[i, j], Symmetric),
     )
     return

test/test_macros.jl

@@ -957,10 +957,9 @@ end
 function test_Model_as_index()
     m = Model()
     @variable(m, x)
-    index_set = VERSION < v"1.1" ? "m=1:2" : "m = 1:2"
     msg = "Index m is the same symbol as the model. Use a different name for the index."
     @test_macro_throws(
-        ErrorException("In `@variable(m, y[$(index_set)] <= m)`: $(msg)"),
+        ErrorException("In `@variable(m, y[m = 1:2] <= m)`: $(msg)"),
         @variable(m, y[m = 1:2] <= m),
     )
     @test_macro_throws(
@@ -982,7 +981,7 @@ function test_Model_as_index()
         @NLexpression(m, [m = 1:2], x),
     )
     @test_macro_throws(
-        ErrorException("In `@NLparameter(m, p[$(index_set)] == m)`: $(msg)"),
+        ErrorException("In `@NLparameter(m, p[m = 1:2] == m)`: $(msg)"),
         @NLparameter(m, p[m = 1:2] == m),
     )
     return