Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease addition of matrix cones #2093

Closed
blegat opened this issue Nov 2, 2019 · 10 comments · Fixed by #3424
Closed

Ease addition of matrix cones #2093

blegat opened this issue Nov 2, 2019 · 10 comments · Fixed by #3424

Comments

@blegat
Copy link
Member

blegat commented Nov 2, 2019

The PSDCone allows to easily add MOI.PositiveSemidefiniteConeTriangle and MOI.PositiveSemidefiniteConeSquare.
There are several other matrix cones, that should work exactly like PSDCone for consistency:

  • SemidefiniteInterval, SemidefiniteGreaterThan and SemidefiniteLessThan that create MOI....Triangle and MOI....Square, see Matrix bounds MathOptInterface.jl#942
  • EigenvalueInterval, EigenvalueGreaterThan and EigenvalueLessThan that create MOI....Triangle and MOI....Square, see Matrix bounds MathOptInterface.jl#942
  • SumOfSquares.DDCone that create SumOfSquares.DiagonalyDominantConeTriangle and SumOfSquares.DiagonalyDominantConeSquare
  • SumOfSquares.SDDCone that create SumOfSquares.ScaledDiagonalyDominantConeTriangle and SumOfSquares.ScaledDiagonalyDominantConeSquare

To allow reusing the code for PSDCone between these different sets we can create a AbstractSymmetricMatrixCone set and the function triangle_vectorized_cone and square_vectorized_cone and then all the code should work for any AbstractSymmetricMatrixCone.

Requires jump-dev/MathOptInterface.jl#942

@odow odow added this to the 1.x milestone Sep 23, 2021
@odow
Copy link
Member

odow commented Dec 7, 2022

@blegat: We haven't made any progress on this. I see what we closed #942, so I'm not sure what Requires #942 is for. Can this be closed? We seem to be getting on okay without it.

@blegat
Copy link
Member Author

blegat commented Dec 8, 2022

I'll take a look whilr adding affine hermitian constraints. It would still be helpful

@odow
Copy link
Member

odow commented Jan 5, 2023

Bump. Is there anything to do here?

@blegat
Copy link
Member Author

blegat commented Jan 6, 2023

Yes, I still need to get at it

@odow
Copy link
Member

odow commented Feb 21, 2023

Can you point me in the right direction? I still don't really understand what you're after.

@blegat
Copy link
Member Author

blegat commented Feb 22, 2023

I'm going to take a look

@odow
Copy link
Member

odow commented Jun 23, 2023

Can you be a little more explicit in what you want here? For example, links to the bits in other packages that would be de-duplicated?

@blegat
Copy link
Member Author

blegat commented Jun 24, 2023

These are the cones: https://github.com/jump-dev/SumOfSquares.jl/blob/8476c96d0fc182377a3a585222714061925092ab/src/diagonally_dominant.jl
I haved made it possible to use them from JuMP as it would be duplicating the code

@odow
Copy link
Member

odow commented Jun 24, 2023

So you want a fallback for any MOI.AbstractSymmetricMatrixSetTriangle?

@blegat
Copy link
Member Author

blegat commented Jun 24, 2023

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants