Report result_count in solution_summary by default #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.68% // Head: 97.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3138 +/- ##
=======================================
Coverage 97.68% 97.69%
=======================================
Files 33 33
Lines 4456 4460 +4
=======================================
+ Hits 4353 4357 +4
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@blegat suggests |
mlubin
reviewed
Dec 9, 2022
odow
force-pushed
the
od/multiple-solution-summary
branch
from
0b1a0b5 to
e4d753f
Compare
mlubin
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3136
The backstory to this is that https://discourse.julialang.org/t/mosek-does-not-give-the-optimal-value-derived-by-simplex-methods/90727 would have been a lot more obvious to debug if
result_countwas reported by default insolution_summary.I'm open to other suggestions about how we could communicate this. The
Solution #1 (default)comes from #3136, but it doesn't really apply whenresult_count = 0. Should we even report primal/dual status then?