Warn on unsupported types

Author: odow

src/Utilities/penalty_relaxation.jl

@@ -115,10 +115,7 @@ function PenaltyRelaxation(
     return PenaltyRelaxation(convert(Dict{MOI.ConstraintIndex,T}, d); kwargs...)
 end
 
-function MOI.modify(
-    model::MOI.ModelLike,
-    relax::PenaltyRelaxation{T},
-) where {T}
+function MOI.modify(model::MOI.ModelLike, relax::PenaltyRelaxation{T}) where {T}
     sense = MOI.get(model, MOI.ObjectiveSense())
     if sense == MOI.FEASIBILITY_SENSE
         MOI.set(model, MOI.ObjectiveSense(), MOI.MIN_SENSE)
@@ -147,10 +144,18 @@ end
 
 function MOI.modify(
     ::MOI.ModelLike,
-    ::MOI.ConstraintIndex,
+    ci::MOI.ConstraintIndex,
     ::PenaltyRelaxation,
 )
-    return  # Silently skip modifying other constraint types.
+    # We use this fallback to avoid ambiguity errors that would occur if we
+    # added {F,S} directly to the argument.
+    _eltype(::MOI.ConstraintIndex{F,S}) where {F,S} = F, S
+    F, S = _eltype(ci)
+    @warn(
+        "Skipping PenaltyRelaxation of constraints of type $F-in-$S",
+        maxlog = 1,
+    )
+    return
 end
 
 function MOI.modify(

test/Utilities/penalty_relaxation.jl

@@ -33,24 +33,34 @@ function _test_roundtrip(src_str, relaxed_str)
 end
 
 function test_relax_bounds()
-    _test_roundtrip(
-        """
-        variables: x, y
-        minobjective: x + y
-        x >= 0.0
-        y <= 0.0
-        x in ZeroOne()
-        y in Integer()
-        """,
-        """
-        variables: x, y
-        minobjective: x + y
-        x >= 0.0
-        y <= 0.0
-        x in ZeroOne()
-        y in Integer()
-        """,
+    src_str = """
+    variables: x, y
+    minobjective: x + y
+    x >= 0.0
+    y <= 0.0
+    x in ZeroOne()
+    y in Integer()
+    """
+    relaxed_str = """
+    variables: x, y
+    minobjective: x + y
+    x >= 0.0
+    y <= 0.0
+    x in ZeroOne()
+    y in Integer()
+    """
+    model = MOI.Utilities.Model{Float64}()
+    MOI.Utilities.loadfromstring!(model, src_str)
+    @test_logs(
+        (:warn,),
+        (:warn,),
+        (:warn,),
+        (:warn,),
+        MOI.modify(model, MOI.Utilities.PenaltyRelaxation()),
     )
+    dest = MOI.Utilities.Model{Float64}()
+    MOI.Utilities.loadfromstring!(dest, relaxed_str)
+    MOI.Bridges._test_structural_identical(model, dest)
     return
 end