Fix various performance issues (#1821)

Author: odow

src/Utilities/DoubleDicts.jl

@@ -94,7 +94,10 @@ mutable struct IndexDoubleDictInner{F,S} <:
                AbstractDoubleDictInner{F,S,MOI.ConstraintIndex{F,S}}
     dict::Dict{Int64,Int64}
     function IndexDoubleDictInner{F,S}(d::IndexDoubleDict) where {F,S}
-        return new{F,S}(get!(d.dict, (F, S), Dict{Int64,Int64}()))
+        if !haskey(d.dict, (F, S))
+            d.dict[(F, S)] = Dict{Int64,Int64}()
+        end
+        return new{F,S}(d.dict[(F, S)])
     end
 end
 

src/Utilities/copy.jl

@@ -242,17 +242,28 @@ Copy the constraints `cis_src` from the model `src` to the model `dest` and fill
 function _copy_constraints(
     dest::MOI.ModelLike,
     src::MOI.ModelLike,
-    index_map::IndexMap,
+    index_map,
+    index_map_FS,
     cis_src::Vector{<:MOI.ConstraintIndex},
 )
     for ci in cis_src
         f = MOI.get(src, MOI.ConstraintFunction(), ci)
         s = MOI.get(src, MOI.ConstraintSet(), ci)
-        index_map[ci] = MOI.add_constraint(dest, map_indices(index_map, f), s)
+        index_map_FS[ci] =
+            MOI.add_constraint(dest, map_indices(index_map, f), s)
     end
     return
 end
 
+function _copy_constraints(
+    dest::MOI.ModelLike,
+    src::MOI.ModelLike,
+    index_map,
+    cis_src::Vector{MOI.ConstraintIndex{F,S}},
+) where {F,S}
+    return _copy_constraints(dest, src, index_map, index_map[F, S], cis_src)
+end
+
 function pass_nonvariable_constraints_fallback(
     dest::MOI.ModelLike,
     src::MOI.ModelLike,

src/Utilities/copy/index_map.jl

@@ -67,6 +67,10 @@ function Base.getindex(map::IndexMap, key::MOI.ConstraintIndex{F,S}) where {F,S}
     return map.con_map[key]::MOI.ConstraintIndex{F,S}
 end
 
+function Base.getindex(map::IndexMap, ::Type{F}, ::Type{S}) where {F,S}
+    return map.con_map[F, S]
+end
+
 function Base.setindex!(
     map::IndexMap,
     value::MOI.VariableIndex,

src/Utilities/functions.jl

@@ -184,22 +184,25 @@ end
 # Functions
 
 function map_indices(index_map::F, f::MOI.VectorOfVariables) where {F<:Function}
-    return MOI.VectorOfVariables(index_map.(f.variables))
+    return MOI.VectorOfVariables([index_map(x) for x in f.variables])
 end
 
 function map_indices(
     index_map::F,
     f::Union{MOI.ScalarAffineFunction,MOI.VectorAffineFunction},
 ) where {F<:Function}
-    return typeof(f)(map_indices.(index_map, f.terms), MOI.constant(f))
+    return typeof(f)(
+        [map_indices(index_map, t) for t in f.terms],
+        MOI.constant(f),
+    )
 end
 
 function map_indices(
     index_map::F,
     f::Union{MOI.ScalarQuadraticFunction,MOI.VectorQuadraticFunction},
 ) where {F<:Function}
-    affine_terms = map_indices.(index_map, f.affine_terms)
-    quadratic_terms = map_indices.(index_map, f.quadratic_terms)
+    affine_terms = [map_indices(index_map, t) for t in f.affine_terms]
+    quadratic_terms = [map_indices(index_map, t) for t in f.quadratic_terms]
     return typeof(f)(quadratic_terms, affine_terms, MOI.constant(f))
 end