Ignore zero-length page_config.json, restore previous behavior of crashing for invalid JSON (#1405)

holzman · web-flow · commit 0adfb2a06a0f · 2024-03-13T11:09:10.000-05:00
diff --git a/jupyter_server/config_manager.py b/jupyter_server/config_manager.py
@@ -101,7 +101,7 @@ def get(self, section_name: str, include_root: bool = True) -> dict[str, t.Any]:
         )
         data: dict[str, t.Any] = {}
         for path in paths:
-            if os.path.isfile(path):
+            if os.path.isfile(path) and os.path.getsize(path):
                 with open(path, encoding="utf-8") as f:
                     try:
                         recursive_update(data, json.load(f))

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ def get(self, section_name: str, include_root: bool = True) -> dict[str, t.Any]:`
`101`	`101`	`)`
`102`	`102`	`data: dict[str, t.Any] = {}`
`103`	`103`	`for path in paths:`
`104`		`- if os.path.isfile(path):`
	`104`	`+ if os.path.isfile(path) and os.path.getsize(path):`
`105`	`105`	`with open(path, encoding="utf-8") as f:`
`106`	`106`	`try:`
`107`	`107`	`recursive_update(data, json.load(f))`