Skip to content

Commit 30f2cac

Browse files
committed
Setup prometheus metric on server start, not import
1 parent ebe2f8e commit 30f2cac

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

jupyter_server/prometheus/metrics.py

-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
from .._version import __version__
4242

4343
SERVER_INFO = Info("jupyter_server_info", "Jupyter Server Version information")
44-
SERVER_INFO.info({"version": __version__})
4544

4645
__all__ = [
4746
"HTTP_REQUEST_DURATION_SECONDS",

jupyter_server/serverapp.py

+8
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
AsyncMappingKernelManager,
124124
MappingKernelManager,
125125
)
126+
from jupyter_server.prometheus.metrics import SERVER_INFO
126127
from jupyter_server.services.sessions.sessionmanager import SessionManager
127128
from jupyter_server.utils import (
128129
JupyterServerAuthWarning,
@@ -2696,6 +2697,12 @@ def _init_asyncio_patch() -> None:
26962697
# prefer Selector to Proactor for tornado + pyzmq
26972698
asyncio.set_event_loop_policy(WindowsSelectorEventLoopPolicy())
26982699

2700+
def init_metrics(self) -> None:
2701+
"""
2702+
Initialize any prometheus metrics that need to be set up on server startup
2703+
"""
2704+
SERVER_INFO.info({"version": __version__})
2705+
26992706
@catch_config_error
27002707
def initialize(
27012708
self,
@@ -2763,6 +2770,7 @@ def initialize(
27632770
self.load_server_extensions()
27642771
self.init_mime_overrides()
27652772
self.init_shutdown_no_activity()
2773+
self.init_metrics()
27662774
if new_httpserver:
27672775
self.init_httpserver()
27682776

0 commit comments

Comments
 (0)