Skip to content

Commit fc7add5

Browse files
committed
enhance-verification-for-toggling-extensions
1 parent 132cf04 commit fc7add5

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

jupyter_server/extension/serverextension.py

+16-2
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,23 @@ def toggle_server_extension(self, import_name: str) -> None:
259259
self.log.info(f"- Writing config: {config_dir}")
260260
# Validate the server extension.
261261
self.log.info(f" - Validating {import_name}...")
262+
config = extension_manager.config_manager
263+
enabled = False
264+
if config:
265+
jpserver_extensions = config.get_jpserver_extensions()
266+
if import_name not in jpserver_extensions:
267+
msg = (
268+
f"The module '{import_name}' could not be found. Are you "
269+
"sure the extension is installed?"
270+
)
271+
raise ValueError(msg)
272+
enabled = jpserver_extensions[import_name]
273+
262274
# Interface with the Extension Package and validate.
263-
extpkg = ExtensionPackage(name=import_name)
264-
extpkg.validate()
275+
extpkg = ExtensionPackage(name=import_name, enabled=enabled)
276+
if not extpkg.validate():
277+
msg = "validation failed"
278+
raise ValueError(msg)
265279
version = extpkg.version
266280
self.log.info(f" {import_name} {version} {GREEN_OK}")
267281

0 commit comments

Comments
 (0)