Skip to content

Commit 279d6d0

Browse files
AnastasiaSliusarJohanMabille
authored andcommitted
Fix JSON schema of metadata of kernel spec parameters
1 parent 9ad2b45 commit 279d6d0

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

jupyter-parameterized-kernel-spec/jupyter-parameterized-kernel-specs.md

+16-14
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Some of the chosen parameter values can be saved in e.g. the notebook metadata s
3030

3131
## Detailed Explanation
3232

33-
As described in previous sections, we propose to parameterize the kernel specs file. In the example shown below, we can see the kernel specs file from the kernel xeus-cling. We suggest changing the last parameter of the execution command `-std=c++11` to have a variable `-std=${parameters.cpp_version}` and adding a new object `parameters` to the metadata of the kernel specs.
33+
As described in previous sections, we propose to parameterize the kernel specs file. In the example shown below, we can see the kernel specs file from the kernel xeus-cling. We suggest changing the last parameter of the execution command `-std=c++11` to have a variable `-std=${cpp_version}` and adding a new object `parameters` to the metadata of the kernel specs.
3434

3535
```=json
3636
{
@@ -54,25 +54,27 @@ As described in previous sections, we propose to parameterize the kernel specs f
5454
"/home/user/micromamba/envs/kernel_spec/bin/xcpp",
5555
"-f",
5656
"{connection_file}",
57-
"-std={parameters.cpp_version}"
57+
"-std={cpp_version}"
5858
],
5959
env: [
60-
"XEUS_LOGLEVEL={parameters.xeus_log_level}"
60+
"XEUS_LOGLEVEL={xeus_log_level}"
6161
],
6262
"language": "C++"
6363
"metadata": {
6464
"parameters": {
65-
"cpp_version": {
66-
"type": "string",
67-
"default": "C++14",
68-
"enum": ["C++11", "C++14", "C++17"],
69-
"save": true
70-
},
71-
"xeus_log_level": {
72-
"type": "string",
73-
"default": "ERROR",
74-
"enum": ["TRACE", "DEBUG", "INFO", "WARN", "ERROR", "FATAL"],
75-
"save": true
65+
"properties": {
66+
"cpp_version": {
67+
"type": "string",
68+
"default": "C++14",
69+
"enum": ["C++11", "C++14", "C++17"],
70+
"save": true
71+
},
72+
"xeus_log_level": {
73+
"type": "string",
74+
"default": "ERROR",
75+
"enum": ["TRACE", "DEBUG", "INFO", "WARN", "ERROR", "FATAL"],
76+
"save": true
77+
}
7678
}
7779
}
7880
},

0 commit comments

Comments
 (0)