Skip to content

Commit d4f3450

Browse files
authored
Merge pull request #181 from datalayer-externals/fix/setup-align
Align setup.py and setup.cfg
2 parents 45a8470 + ac42091 commit d4f3450

File tree

4 files changed

+50
-84
lines changed

4 files changed

+50
-84
lines changed

nbclassic/static/base/js/namespace.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ define(function(){
7373
// tree
7474
jglobal('SessionList','tree/js/sessionlist');
7575

76-
Jupyter.version = "0.4.8";
76+
Jupyter.version = "0.5.0.dev0";
7777
Jupyter._target = '_blank';
7878

7979
return Jupyter;

pyproject.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
[build-system]
2-
requires = ["jupyter_packaging~=0.9,<2", "babel"]
2+
requires = [
3+
"jupyter_packaging~=0.9,<2",
4+
"jupyter_server>=1.17.0",
5+
"babel"
6+
]
37
build-backend = "jupyter_packaging.build_api"
48

59
[tool.check-manifest]

setup.cfg

Lines changed: 44 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
[metadata]
22
name = nbclassic
3-
version = attr: nbclassic.__version__.__version__
3+
version = attr: nbclassic.__version__
44
description = Jupyter Notebook as a Jupyter Server extension.
55
long_description = file: README.md
66
long_description_content_type = text/markdown
7-
license_file = LICENSE
7+
license = BSD-3-Clause
8+
license_files = LICENSE
89
author = Jupyter Development Team
910
author_email = [email protected]
1011
url = https://jupyter.org
1112
platforms = Linux, Mac OS X, Windows
12-
keywords = ipython, jupyter
13+
keywords = ipython, jupyter, interactive, interpreter, shell, web
1314
classifiers =
1415
Intended Audience :: Developers
1516
Intended Audience :: System Administrators
@@ -27,8 +28,27 @@ include_package_data = True
2728
packages = find:
2829
python_requires = >=3.7
2930
install_requires =
30-
notebook_shim>=0.1.0
31+
jinja2
32+
tornado>=6.1
33+
# pyzmq>=17 is not technically necessary,
34+
# but hopefully avoids incompatibilities with Tornado 5. April 2018
35+
pyzmq>=17
36+
argon2-cffi
37+
traitlets>=4.2.1
38+
jupyter_core>=4.6.1
39+
jupyter_client>=6.1.1
3140
jupyter_server>=1.17.0
41+
ipython_genutils
42+
jupyter_server>=1.8
43+
nbformat
44+
notebook_shim>=0.1.0
45+
notebook_shim>=0.1.0
46+
nbconvert>=5
47+
nest-asyncio>=1.5
48+
ipykernel # bless IPython kernel for now
49+
Send2Trash>=1.8.0
50+
terminado>=0.8.3
51+
prometheus_client
3252

3353
[options.data_files]
3454
etc/jupyter/jupyter_server_config.d =
@@ -38,16 +58,32 @@ share/applications =
3858
share/icons/hicolor/scalable/apps =
3959
nbclassic.svg
4060

41-
4261
[options.extras_require]
4362
test =
4463
pytest
45-
pytest-tornasync
46-
pytest-console-scripts
64+
coverage
65+
requests
66+
testpath
67+
nbval
68+
pytest-playwright
69+
pytest-cov
70+
pytest_tornasync
71+
requests-unixsocket; sys_platform != "win32"
72+
docs =
73+
sphinx
74+
nbsphinx
75+
sphinxcontrib_github_alt
76+
sphinx_rtd_theme
77+
myst-parser
78+
json-logging =
79+
json-logging
4780

4881
[options.entry_points]
4982
console_scripts =
5083
jupyter-nbclassic = nbclassic.notebookapp:main
84+
jupyter-nbclassic-extension = nbclassic.nbextensions:main
85+
jupyter-nbclassic-serverextension = nbclassic.serverextensions:main
86+
jupyter-nbclassic-bundlerextension = nbclassic.bundler.bundlerextensions:main
5187

5288
[options.packages.find]
5389
exclude =
@@ -61,4 +97,4 @@ exclude =
6197
.cache,
6298
.github,
6399
docs,
64-
setup.py
100+
setup.py

setup.py

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@
1313
import os
1414
import sys
1515

16-
name = "nbclassic"
17-
1816
if sys.version_info < (3, 6):
1917
pip_message = 'This may be due to an out of date pip. Make sure you have pip >= 9.0.1.'
2018
try:
@@ -66,78 +64,6 @@
6664

6765

6866
setup_args = dict(
69-
name = name,
70-
description = "A web-based notebook environment for interactive computing",
71-
long_description = """
72-
The Jupyter NbClassic is a web application that allows you to create and
73-
share documents that contain live code, equations, visualizations, and
74-
explanatory text. The NbClassic has support for multiple programming
75-
languages, sharing, and interactive widgets.
76-
77-
Read `the documentation <https://jupyter-notebook.readthedocs.io>`_
78-
for more information.
79-
""",
80-
long_description_content_type = 'text/markdown',
81-
version = version,
82-
packages = find_packages(),
83-
package_data = find_package_data(),
84-
author = 'Jupyter Development Team',
85-
author_email = '[email protected]',
86-
url = 'http://jupyter.org',
87-
license = 'BSD',
88-
platforms = "Linux, Mac OS X, Windows",
89-
keywords = ['Interactive', 'Interpreter', 'Shell', 'Web'],
90-
classifiers = [
91-
'Intended Audience :: Developers',
92-
'Intended Audience :: System Administrators',
93-
'Intended Audience :: Science/Research',
94-
'License :: OSI Approved :: BSD License',
95-
'Programming Language :: Python',
96-
'Programming Language :: Python :: 3',
97-
'Programming Language :: Python :: 3.7',
98-
'Programming Language :: Python :: 3.8',
99-
'Programming Language :: Python :: 3.9',
100-
'Programming Language :: Python :: 3.10',
101-
],
102-
zip_safe = False,
103-
install_requires = [
104-
'jinja2',
105-
'tornado>=6.1',
106-
# pyzmq>=17 is not technically necessary,
107-
# but hopefully avoids incompatibilities with Tornado 5. April 2018
108-
'pyzmq>=17',
109-
'argon2-cffi',
110-
'traitlets>=4.2.1',
111-
'jupyter_core>=4.6.1',
112-
'jupyter_client>=6.1.1',
113-
'ipython_genutils',
114-
'jupyter_server>=1.8',
115-
'nbformat',
116-
'notebook_shim>=0.1.0',
117-
'nbconvert>=5',
118-
'nest-asyncio>=1.5',
119-
'ipykernel', # bless IPython kernel for now
120-
'Send2Trash>=1.8.0',
121-
'terminado>=0.8.3',
122-
'prometheus_client'
123-
],
124-
extras_require = {
125-
'test': ['pytest', 'coverage', 'requests', 'testpath',
126-
'nbval', 'pytest-playwright', 'pytest-cov', 'pytest_tornasync'],
127-
'docs': ['sphinx', 'nbsphinx', 'sphinxcontrib_github_alt',
128-
'sphinx_rtd_theme', 'myst-parser'],
129-
'test:sys_platform != "win32"': ['requests-unixsocket'],
130-
'json-logging': ['json-logging']
131-
},
132-
python_requires = '>=3.7',
133-
entry_points = {
134-
'console_scripts': [
135-
'jupyter-nbclassic = nbclassic.notebookapp:main',
136-
'jupyter-nbclassic-extension = nbclassic.nbextensions:main',
137-
'jupyter-nbclassic-serverextension = nbclassic.serverextensions:main',
138-
'jupyter-nbclassic-bundlerextension = nbclassic.bundler.bundlerextensions:main',
139-
]
140-
},
14167
)
14268

14369
# Custom distutils/setuptools commands ----------

0 commit comments

Comments
 (0)