Error with nbclassic==0.4.0, JupyterLab<4 and notebook<7

[brichet]

This check :

nbclassic/nbclassic/__init__.py

Lines 45 to 46 in 3ebe3d7

	from notebook.base.handlers import IPythonHandler as NotebookIPythonHandler
	assert NotebookIPythonHandler.__name__ == "JupyterHandler"

seems to work only if Notebook is not installed or in a version >= 7.

Running :

pip install "jupyterlab<4"
pip install "notebook<7"
jupyter server extension list

raises :

File "/home/brichet/miniconda3/envs/nbclassic-test/lib/python3.10/site-packages/nbclassic/__init__.py", line 46, in <module>
    assert NotebookIPythonHandler.__name__ == "JupyterHandler"
AssertionError

which is logic because the following command works :

nbclassic/nbclassic/__init__.py

Lines 12 to 13 in 3ebe3d7

	try:
	from notebook._version import __version__ as notebook_version

Maybe a test on the notebook version is missing ?

If this is the desired behavior this issue should be opened in JupyterLab 3.4.x to pin the nbclassic version <0.4.0.

[echarles]

Thx for reporting. We have been discussing that in #120 (comment)

I have opened a fix on #122