Skip to content

Commit bb906e2

Browse files
committed
Add return value types and update descriptions
1 parent f2a410e commit bb906e2

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

src/components/NewBranchDialog.tsx

+12-9
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,9 @@ export class NewBranchDialog extends React.Component<
133133
/**
134134
* Renders the component.
135135
*
136-
* @returns fragment
136+
* @returns React element
137137
*/
138-
render() {
138+
render(): React.ReactElement {
139139
return (
140140
<Dialog
141141
classes={{
@@ -214,9 +214,9 @@ export class NewBranchDialog extends React.Component<
214214
/**
215215
* Renders branch menu items.
216216
*
217-
* @returns fragment array
217+
* @returns array of React elements
218218
*/
219-
private _renderItems() {
219+
private _renderItems(): React.ReactElement[] {
220220
const current = this.props.model.currentBranch.name;
221221
return this.state.branches
222222
.slice()
@@ -244,9 +244,12 @@ export class NewBranchDialog extends React.Component<
244244
*
245245
* @param branch - branch
246246
* @param idx - item index
247-
* @returns fragment
247+
* @returns React element
248248
*/
249-
private _renderItem(branch: Git.IBranch, idx: number) {
249+
private _renderItem(
250+
branch: Git.IBranch,
251+
idx: number
252+
): React.ReactElement | null {
250253
// Perform a "simple" filter... (TODO: consider implementing fuzzy filtering)
251254
if (this.state.filter && !branch.name.includes(this.state.filter)) {
252255
return null;
@@ -364,7 +367,7 @@ export class NewBranchDialog extends React.Component<
364367
* @private
365368
* @param event - event object
366369
*/
367-
function onClick() {
370+
function onClick(): void {
368371
self.setState({
369372
base: branch
370373
});
@@ -424,7 +427,7 @@ export class NewBranchDialog extends React.Component<
424427
* @private
425428
* @param result - result
426429
*/
427-
function onResolve(result: any) {
430+
function onResolve(result: any): void {
428431
if (result.code !== 0) {
429432
showErrorMessage('Error creating branch', result.message);
430433
}
@@ -436,7 +439,7 @@ export class NewBranchDialog extends React.Component<
436439
* @private
437440
* @param err - error
438441
*/
439-
function onError(err: any) {
442+
function onError(err: any): void {
440443
showErrorMessage('Error creating branch', err.message);
441444
}
442445
}

0 commit comments

Comments
 (0)