Skip to content

Commit c61f247

Browse files
committed
Update return types
1 parent fcb6b42 commit c61f247

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/components/BranchMenu.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ export class BranchMenu extends React.Component<
105105
/**
106106
* Renders the component.
107107
*
108-
* @returns fragment
108+
* @returns React element
109109
*/
110-
render() {
110+
render(): React.ReactElement {
111111
return (
112112
<div className={wrapperClass}>
113113
<div className={filterWrapperClass}>
@@ -155,7 +155,7 @@ export class BranchMenu extends React.Component<
155155
*
156156
* @returns fragment array
157157
*/
158-
private _renderItems() {
158+
private _renderItems(): React.ReactElement[] {
159159
return this.state.branches.map(this._renderItem, this);
160160
}
161161

@@ -166,7 +166,10 @@ export class BranchMenu extends React.Component<
166166
* @param idx - item index
167167
* @returns fragment
168168
*/
169-
private _renderItem(branch: Git.IBranch, idx: number) {
169+
private _renderItem(
170+
branch: Git.IBranch,
171+
idx: number
172+
): React.ReactElement | null {
170173
// Perform a "simple" filter... (TODO: consider implementing fuzzy filtering)
171174
if (this.state.filter && !branch.name.includes(this.state.filter)) {
172175
return null;
@@ -278,7 +281,7 @@ export class BranchMenu extends React.Component<
278281
* @private
279282
* @param event - event object
280283
*/
281-
function onClick() {
284+
function onClick(): void {
282285
if (!self.props.branching) {
283286
showErrorMessage('Switching branches is disabled', CHANGES_ERR_MSG);
284287
return;
@@ -298,7 +301,7 @@ export class BranchMenu extends React.Component<
298301
* @private
299302
* @param result - result
300303
*/
301-
function onResolve(result: any) {
304+
function onResolve(result: any): void {
302305
if (result.code !== 0) {
303306
showErrorMessage('Error switching branch', result.message);
304307
}
@@ -310,7 +313,7 @@ export class BranchMenu extends React.Component<
310313
* @private
311314
* @param err - error
312315
*/
313-
function onError(err: any) {
316+
function onError(err: any): void {
314317
showErrorMessage('Error switching branch', err.message);
315318
}
316319
}

0 commit comments

Comments
 (0)