Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging #9

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add logging #9

wants to merge 1 commit into from

Conversation

jonniesweb
Copy link

Throwing up a rough PR at the moment to get this logging idea out there.

For newcomers to the library it's useful to know when messages/interactions/events are unhandled and which are handled. Adding this logging gives some insight into this.

So far I've added the basic logging configuration and started adding some logging to the Router class so far.

Enjoying the library so far! Looking forward to the day when #4 is figured out.

@jusleg
Copy link
Owner

jusleg commented Aug 17, 2020

Hey Jon 👋 thanks for the PR. This seems like a good start. I agree with you, adding logging is a great idea. The app could be more verbose when it comes to how it obtains the proper handler/action combo. We could also add logs for the interactive route.

I'm fine with the code changes. I would add a test or two for expectation of logs and then call it a day. Let me know if you want me to write the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants