From 655a7d2eb339b501d0b39e961c653163cd22cef3 Mon Sep 17 00:00:00 2001 From: hrithikesh026 Date: Thu, 8 Feb 2024 16:20:18 +0530 Subject: [PATCH] address comments --- crates/router/src/connector/cryptopay/transformers.rs | 11 +++++++++-- crates/router/src/connector/payme/transformers.rs | 4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/crates/router/src/connector/cryptopay/transformers.rs b/crates/router/src/connector/cryptopay/transformers.rs index f8912c4f61f..d4697e3ba14 100644 --- a/crates/router/src/connector/cryptopay/transformers.rs +++ b/crates/router/src/connector/cryptopay/transformers.rs @@ -5,6 +5,7 @@ use serde::{Deserialize, Serialize}; use crate::{ connector::utils::{self, is_payment_failure, CryptoData}, + consts, core::errors, services, types::{self, api, storage::enums}, @@ -159,8 +160,14 @@ impl let response = if is_payment_failure(status) { let payment_response = &item.response.data; Err(types::ErrorResponse { - code: payment_response.name.clone().unwrap_or_default(), - message: payment_response.status_context.clone().unwrap_or_default(), + code: payment_response + .name + .clone() + .unwrap_or(consts::NO_ERROR_CODE.to_string()), + message: payment_response + .status_context + .clone() + .unwrap_or(consts::NO_ERROR_MESSAGE.to_string()), reason: payment_response.status_context.clone(), status_code: item.http_code, attempt_status: None, diff --git a/crates/router/src/connector/payme/transformers.rs b/crates/router/src/connector/payme/transformers.rs index 146c87afb60..f4e34c084d9 100644 --- a/crates/router/src/connector/payme/transformers.rs +++ b/crates/router/src/connector/payme/transformers.rs @@ -314,7 +314,7 @@ impl From<(&SaleQuery, u16)> for types::ErrorResponse { reason: sale_query_response.sale_error_text.clone(), status_code: http_code, attempt_status: None, - connector_transaction_id: sale_query_response.sale_error_code.clone(), + connector_transaction_id: Some(sale_query_response.sale_payme_id.clone()), } } } @@ -1000,7 +1000,7 @@ impl TryFrom Err(types::ErrorResponse { code: payme_response.status_error_code.to_string(), message: payme_response.status_error_code.to_string(), - reason: None, + reason: Some(payme_response.status_error_code.to_string()), status_code: item.http_code, attempt_status: None, connector_transaction_id: Some(payme_response.payme_transaction_id.clone()),