Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retest scripts #122

Closed
RichardWarburton opened this issue Apr 27, 2016 · 2 comments
Closed

Retest scripts #122

RichardWarburton opened this issue Apr 27, 2016 · 2 comments
Labels

Comments

@RichardWarburton
Copy link
Member

@neomatrix369 reported that he was getting the following errors when running scripts:

readlink: illegal option -- f
usage: readlink [-n] [file …]
@FauxFaux
Copy link
Contributor

Since 3a7c62c, the scripts are pretty broken on Debian/Ubuntu.

Their "alternatives" system means there's multiple layers of symlinks in front of javac:

% readlink $(which javac)
/etc/alternatives/javac
% readlink -f $(which javac)     
/usr/lib/jvm/java-8-oracle/bin/javac

This is what the readlink -f was resolving.

Additionally, the refactor broke the sed expression by moving the concatenation before the edit:

java_home=$(echo ${java_path}../ | sed 's/javac$//'.

@cinquin
Copy link
Contributor

cinquin commented Apr 11, 2017

I didn't realize my commit broke things under Linux, but please note that we're now just back to a state where things are broken under OS X instead (as pointed out in issue #207).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants