Add unit tests for bit manipulation instructions

Author: k0ekk0ek

src/westmere/bits.h

@@ -11,6 +11,7 @@
 
 #include <stdbool.h>
 #include <stdint.h>
+#include <immintrin.h>
 
 static inline bool add_overflow(uint64_t value1, uint64_t value2, uint64_t *result) {
 #if has_builtin(__builtin_uaddll_overflow)

tests/CMakeLists.txt

@@ -1,5 +1,14 @@
 find_package(cmocka REQUIRED)
-cmocka_add_tests(zone-tests types.c include.c ip4.c time.c base32.c svcb.c syntax.c eui.c)
+if(HAVE_WESTMERE)
+  set(sources ${sources} bits-westmere.c)
+  set_source_files_properties(bits-westmere.c PROPERTIES COMPILE_FLAGS "-march=westmere")
+endif()
+if(HAVE_HASWELL)
+  set(sources ${sources} bits-haswell.c)
+  set_source_files_properties(bits-haswell.c PROPERTIES COMPILE_FLAGS "-march=haswell")
+endif()
+
+cmocka_add_tests(zone-tests types.c include.c ip4.c time.c base32.c svcb.c syntax.c eui.c ${sources})
 
 target_link_libraries(zone-tests PRIVATE zone)
 target_sources(zone-tests PRIVATE tools.c)

tests/bits-haswell.c

@@ -0,0 +1,52 @@
+/*
+ * bits-haswell.c -- test Haswell specific bit manipulation instructions
+ *
+ * Copyright (c) 2024, NLnet Labs. All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ *
+ */
+#include <stdarg.h>
+#include <setjmp.h>
+#include <string.h>
+#include <cmocka.h>
+
+#include "attributes.h"
+#include "haswell/bits.h"
+
+/*!cmocka */
+void haswell_trailing_zeroes(void **state)
+{
+  (void)state;
+  for (uint64_t shift = 0; shift < 63; shift++) {
+    uint64_t bit = 1llu << shift;
+    uint64_t tz = trailing_zeroes(bit);
+    assert_int_equal(tz, shift);
+  }
+}
+
+/*!cmocka */
+void haswell_leading_zeroes(void **state)
+{
+  (void)state;
+  for (uint64_t shift = 0; shift << 63; shift++) {
+    const uint64_t bit = 1llu << shift;
+    uint64_t lz = leading_zeroes(bit);
+    assert_int_equal(lz, 63 - shift);
+  }
+}
+
+/*!cmocka */
+void haswell_prefix_xor(void **state)
+{
+  (void)state;
+  // "0001 0001 0000 0101 0000 0110 0000 0000"
+  const uint64_t mask = 0x11050600llu;
+  // "0001 1110 0000 0110 0000 0100 0000 0000"
+  const uint64_t xor_mask = 0x1E060400llu;
+
+  assert_int_equal(prefix_xor(mask), xor_mask);
+}
+
+/*!cm ocka */
+// add_overflow

tests/bits-westmere.c

@@ -0,0 +1,52 @@
+/*
+ * bits-westmere.c -- test Westmere specific bit manipulation instructions
+ *
+ * Copyright (c) 2024, NLnet Labs. All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ *
+ */
+#include <stdarg.h>
+#include <setjmp.h>
+#include <string.h>
+#include <cmocka.h>
+
+#include "attributes.h"
+#include "westmere/bits.h"
+
+/*!cmocka */
+void westmere_trailing_zeroes(void **state)
+{
+  (void)state;
+  for (uint64_t shift = 0; shift < 63; shift++) {
+    uint64_t bit = 1llu << shift;
+    uint64_t tz = trailing_zeroes(bit);
+    assert_int_equal(tz, shift);
+  }
+}
+
+/*!cmocka */
+void westmere_leading_zeroes(void **state)
+{
+  (void)state;
+  for (uint64_t shift = 0; shift << 63; shift++) {
+    const uint64_t bit = 1llu << shift;
+    uint64_t lz = leading_zeroes(bit);
+    assert_int_equal(lz, 63 - shift);
+  }
+}
+
+/*!cmocka */
+void westmere_prefix_xor(void **state)
+{
+  (void)state;
+  // "0001 0001 0000 0101 0000 0110 0000 0000"
+  const uint64_t mask = 0x11050600llu;
+  // "0001 1110 0000 0110 0000 0100 0000 0000"
+  const uint64_t xor_mask = 0x1E060400llu;
+
+  assert_int_equal(prefix_xor(mask), xor_mask);
+}
+
+/*!cm ocka */
+// add_overflow