Copy a parsed 8-bit integer only once

k0ekk0ek · k0ekk0ek · commit 7db4a1c2b738 · 2024-03-27T14:06:49.000+01:00
diff --git a/src/generic/number.h b/src/generic/number.h
@@ -86,7 +86,6 @@ static really_inline int32_t parse_int8(
   uint8_t number;
   if (!scan_int8(token->data, token->length, &number))
     SYNTAX_ERROR(parser, "Invalid %s in %s", NAME(field), NAME(type));
-  memcpy(rdata->octets, &number, 1);
   *rdata->octets++ = number;
   return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,6 @@ static really_inline int32_t parse_int8(`
`86`	`86`	`uint8_t number;`
`87`	`87`	`if (!scan_int8(token->data, token->length, &number))`
`88`	`88`	`SYNTAX_ERROR(parser, "Invalid %s in %s", NAME(field), NAME(type));`
`89`		`- memcpy(rdata->octets, &number, 1);`
`90`	`89`	`*rdata->octets++ = number;`
`91`	`90`	`return 0;`
`92`	`91`	`}`