Skip to content

Commit fd000f5

Browse files
committed
slight improv in ImageCrawler deduplication checks
1 parent c343f60 commit fd000f5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

nichtparasoup/core/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def _add_image_to_blacklist(self, image: Image) -> None:
142142
self.blacklist.add(image.uri)
143143

144144
def has_imagecrawler(self, imagecrawler: BaseImageCrawler) -> bool:
145-
return imagecrawler in [crawler.imagecrawler for crawler in self.crawlers]
145+
return imagecrawler in (crawler.imagecrawler for crawler in self.crawlers)
146146

147147
def add_imagecrawler(self, imagecrawler: BaseImageCrawler, weight: _CrawlerWeight) -> None:
148148
self.crawlers.append(Crawler(

nichtparasoup/testing/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class ConfigFileTest(TestCase):
1313
def validate(self, file: str) -> None:
1414
config = parse_yaml_file(file)
1515
self.assertIsInstance(config, dict)
16-
imagecrawlers = [] # type: List[BaseImageCrawler]
16+
imagecrawlers = list() # type: List[BaseImageCrawler]
1717
for crawler_config in config['crawlers']:
1818
imagecrawler = get_imagecrawler(crawler_config)
1919
self.assertNotIn(imagecrawler, imagecrawlers, msg='Duplicate ImageCrawler')

0 commit comments

Comments
 (0)