add unit tests

Signed-off-by: Miguel Duarte Barroso <[email protected]>

Author: maiqueb

pkg/multuscni/client.go

@@ -25,6 +25,7 @@ type Client interface {
 
 type HttpClient struct {
 	httpClient *http.Client
+	serverURL  string
 }
 
 func NewClient(socketPath string) *HttpClient {
@@ -36,11 +37,12 @@ func NewClient(socketPath string) *HttpClient {
 				},
 			},
 		},
+		serverURL: MultusDelegateURL(),
 	}
 }
 
 func (c *HttpClient) InvokeDelegate(req *multusapi.Request) (*multusapi.Response, error) {
-	httpResp, err := c.DoCNI(MultusDelegateURL(), req)
+	httpResp, err := c.DoCNI(req)
 	if err != nil {
 		return nil, err
 	}
@@ -53,13 +55,13 @@ func (c *HttpClient) InvokeDelegate(req *multusapi.Request) (*multusapi.Response
 	return response, nil
 }
 
-func (c *HttpClient) DoCNI(url string, req interface{}) ([]byte, error) {
+func (c *HttpClient) DoCNI(req interface{}) ([]byte, error) {
 	data, err := json.Marshal(req)
 	if err != nil {
 		return nil, fmt.Errorf("failed to marshal CNI request %v: %v", req, err)
 	}
 
-	resp, err := c.httpClient.Post(url, "application/json", bytes.NewReader(data))
+	resp, err := c.httpClient.Post(c.serverURL, "application/json", bytes.NewReader(data))
 	if err != nil {
 		return nil, fmt.Errorf("failed to send CNI request: %v", err)
 	}

pkg/multuscni/client_test.go

@@ -0,0 +1,109 @@
+package multuscni
+
+import (
+	"encoding/json"
+	"github.com/containernetworking/cni/pkg/types"
+	cni100 "github.com/containernetworking/cni/pkg/types/100"
+	"net"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+
+	multusapi "gopkg.in/k8snetworkplumbingwg/multus-cni.v3/pkg/server/api"
+)
+
+func TestController(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Dynamic network attachment controller suite")
+}
+
+var _ = Describe("multuscni REST client", func() {
+	const socketPath = "/over/there"
+
+	BeforeEach(func() {
+
+	})
+
+	It("", func() {
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusBadRequest)
+			_, _ = w.Write([]byte(`kablewit`))
+		}))
+
+		defer server.Close()
+		_, err := newDummyClient(server.Client(), server.URL).InvokeDelegate(multusRequest())
+		Expect(err).To(MatchError("CNI request failed with status 400: 'kablewit'"))
+	})
+
+	It("", func() {
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusOK)
+			_, _ = w.Write([]byte(`{asd:123}`))
+		}))
+
+		defer server.Close()
+		_, err := newDummyClient(server.Client(), server.URL).InvokeDelegate(multusRequest())
+		Expect(err).To(MatchError(ContainSubstring("failed to unmarshal response '{asd:123}':")))
+	})
+
+	It("", func() {
+		response := multusapi.Response{Result: &cni100.Result{
+			CNIVersion: "",
+			Interfaces: []*cni100.Interface{{
+				Name:    "net1",
+				Mac:     "02:03:04:05:06:07",
+				Sandbox: "/over-there",
+			}},
+		}}
+
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusOK)
+			serializedResponse, _ := json.Marshal(response)
+			_, _ = w.Write(serializedResponse)
+		}))
+
+		defer server.Close()
+		Expect(newDummyClient(server.Client(), server.URL).InvokeDelegate(multusRequest())).To(Equal(&response))
+	})
+
+	It("", func() {
+		ip, ipNet, _ := net.ParseCIDR("192.168.14.14/24")
+		ipNet.IP = ip
+		response := multusapi.Response{Result: &cni100.Result{
+			CNIVersion: "",
+			Interfaces: []*cni100.Interface{{
+				Name:    "net1",
+				Mac:     "02:03:04:05:06:07",
+				Sandbox: "/over-there",
+			}},
+			IPs: []*cni100.IPConfig{{
+				Address: *ipNet,
+			}},
+			Routes: nil,
+			DNS:    types.DNS{},
+		}}
+
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusOK)
+			serializedResponse, _ := json.Marshal(response)
+			_, _ = w.Write(serializedResponse)
+		}))
+
+		defer server.Close()
+		Expect(newDummyClient(server.Client(), server.URL).InvokeDelegate(multusRequest())).To(Equal(&response))
+	})
+})
+
+func multusRequest() *multusapi.Request {
+	return &multusapi.Request{
+		Env:    map[string]string{},
+		Config: nil,
+	}
+}
+
+func newDummyClient(httpClient *http.Client, serverURL string) *HttpClient {
+	return &HttpClient{httpClient: httpClient, serverURL: serverURL}
+}