Skip to content

[BUG] Multus 4.1.1 doesnt work with multus dynamic network controller on kubevirtci #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oshoval opened this issue Sep 30, 2024 · 1 comment

Comments

@oshoval
Copy link
Member

oshoval commented Sep 30, 2024

Describe the bug
Once multus is bumped on CNAO to 4.1.1, there are some tests that always fail
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1907/pull-e2e-cnao-multus-dynamic-networks-functests/1839221903835795456

Expected behavior
Should pass

To Reproduce
Steps to reproduce the behavior:
Run the mentioned PR kubevirt/cluster-network-addons-operator#1907

Environment:

  • multus-dynamic-networks-controller version: N/A
  • Kubernetes version (use kubectl version): N/A
  • Network-attachment-definition: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Controller configuration (criSocketPath / multusSocketPath): N/A
  • Kernel (e.g. uname -a): N/A
  • Others: N/A

Additional info / context
Since on kind it does work (latest multus + latest of this repo), lets focus on fixing it on kubevirtci.
Hacking locally kubevirtci to deploy multus 4.1.1 from releases manifests
with latest multus-dynamic-networks-controller from this repo + some changes to the manifest
("cluster-sync" like but without the cluster, nor multus from multus-cni repo) reduce the error count from 5 to 1

@maiqueb can you please issue a release so we can consume it on CNAO and debug the last failure ?

I will post soon the PR that allows cluster-sync of this repo on kubevirtci
so we can debug it locally (having the release will make it easier, and i will double check it before)

Latest issue seems related to the updated network-status as was also raised offline,
but step by step, we first need the infra to be bit more stabilized
and comfortable (allowing to debug locally) by the actions above please.

Thanks

@oshoval
Copy link
Member Author

oshoval commented Oct 1, 2024

A release was created thanks
and also k8snetworkplumbingwg/network-attachment-definition-client#72 was created to fix the latest failing test, due to Calico usage.
(didn't validate yet, but should be the same reason for both macvtap and this one, as both use calico)

Thanks for the co-op

@oshoval oshoval closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant