Skip to content

Commit 8e7838c

Browse files
committed
Bump the version to 2.0, cleanup
* Bump the version of the library to 0.2.0 * Bump Robolectric to 3.0 * Bump gradle plugin to 1.3.0 * Remove unnecessary dependency on okio
1 parent a08e0b7 commit 8e7838c

File tree

8 files changed

+18
-28
lines changed

8 files changed

+18
-28
lines changed

build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ buildscript {
44
}
55
dependencies {
66
classpath "com.android.tools.build:gradle:${ANDROID_GRADLE_PLUGIN_VERSION}"
7-
classpath "org.robolectric:robolectric-gradle-plugin:${ROBOLECTRIC_GRADLE_PLUGIN_VERSION}"
87
classpath "com.jakewharton.sdkmanager:gradle-plugin:${SDKMANAGER_GRADLE_PLUGIN_VERSION}"
98
classpath "com.github.dcendents:android-maven-gradle-plugin:1.3"
109
// NOTE: Do not place your application dependencies here; they belong

gradle.properties

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
org.gradle.daemon=true
22

33
BASE_NAME=spotify-web-api-android
4-
VERSION_NAME=0.1.1
4+
VERSION_NAME=0.2.0
55
GROUP=com.spotify.android
66

77
# Deps for gradle
8-
ANDROID_GRADLE_PLUGIN_VERSION=1.2.3
9-
ROBOLECTRIC_GRADLE_PLUGIN_VERSION=1.1.0
8+
ANDROID_GRADLE_PLUGIN_VERSION=1.3.0
109
SDKMANAGER_GRADLE_PLUGIN_VERSION=0.12.+
1110

1211
# Deps for libraries
1312
FEST_ASSERT_CORE_VERSION=2.0M10
1413
GUAVA_VERSION=18.0
1514
JUNIT_VERSION=4.12
1615
MOCKITO_CORE_VERSION=1.+
17-
ROBOLECTRIC_VERSION=2.4
16+
ROBOLECTRIC_VERSION=3.0

release.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jacoco {
3333

3434
def coverageSourceDirs = ['src/main/java' ]
3535

36-
task jacocoTestReport(type:JacocoReport, dependsOn: "testDebug") {
36+
task jacocoTestReport(type:JacocoReport, dependsOn: "test") {
3737
group = "Reporting"
3838
description = "Generate Jacoco coverage reports"
3939

sample-search/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@ android {
1212
versionName "1.0"
1313
}
1414

15-
lintOptions {
16-
disable 'InvalidPackage' // for okio-1.2.0
17-
}
18-
1915
buildTypes {
2016
release {
2117
minifyEnabled false

spotify-api/build.gradle

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
11
apply plugin: 'android-sdk-manager'
22
apply plugin: 'com.android.library'
3-
apply plugin: 'org.robolectric'
43
apply plugin: 'com.github.dcendents.android-maven'
54

65
project.group = GROUP
76
version = VERSION_NAME
87

98
dependencies {
109
compile('com.squareup.retrofit:retrofit:1.9.0')
11-
compile('com.squareup.okhttp:okhttp:2.2.0')
1210

1311
testCompile("org.robolectric:robolectric:${ROBOLECTRIC_VERSION}") {
1412
exclude group: 'com.android.support', module: 'support-v4'
1513
exclude group: 'commons-logging', module: 'commons-logging'
1614
exclude group: 'org.apache.httpcomponents', module: 'httpclient'
1715
}
18-
testCompile "com.google.guava:guava:${GUAVA_VERSION}"
16+
testCompile "com.google.guava:guava:${GUAVA_VERSION}"
1917
testCompile "junit:junit:${JUNIT_VERSION}"
2018
testCompile "org.easytesting:fest-assert-core:${FEST_ASSERT_CORE_VERSION}"
2119
testCompile "org.mockito:mockito-core:${MOCKITO_CORE_VERSION}"
@@ -27,10 +25,6 @@ android {
2725
compileSdkVersion 23
2826
buildToolsVersion '23.0.2'
2927

30-
lintOptions {
31-
disable 'InvalidPackage' // for okio-1.2.0
32-
}
33-
3428
buildTypes {
3529
debug {
3630
testCoverageEnabled = true

spotify-api/src/main/java/kaaes/spotify/webapi/android/SpotifyService.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1388,42 +1388,44 @@ public interface SpotifyService {
13881388
/**
13891389
* Get the current user's followed artists.
13901390
*
1391+
* @return Object containing a list of artists that user follows wrapped in a cursor object.
13911392
* @see <a href="https://developer.spotify.com/web-api/get-followed-artists/">Get User's Followed Artists</a>
13921393
*/
13931394
@GET("/me/following?type=artist")
1394-
public ArtistsCursorPager getFollowedArtists();
1395+
ArtistsCursorPager getFollowedArtists();
13951396

13961397
/**
13971398
* Get the current user's followed artists.
13981399
*
1399-
* @param callback Callback method.
1400+
* @param callback Callback method.
14001401
* @return An empty result
14011402
* @see <a href="https://developer.spotify.com/web-api/get-followed-artists/">Get User's Followed Artists</a>
14021403
*/
14031404
@GET("/me/following?type=artist")
1404-
public Result getFollowedArtists(Callback<ArtistsCursorPager> callback);
1405+
Result getFollowedArtists(Callback<ArtistsCursorPager> callback);
14051406

14061407
/**
14071408
* Get the current user's followed artists.
14081409
*
1409-
* @param options Optional parameters. For list of supported parameters see
1410-
* <a href="https://developer.spotify.com/web-api/get-followed-artists/">endpoint documentation</a>
1410+
* @param options Optional parameters. For list of supported parameters see
1411+
* <a href="https://developer.spotify.com/web-api/get-followed-artists/">endpoint documentation</a>
1412+
* @return Object containing a list of artists that user follows wrapped in a cursor object.
14111413
* @see <a href="https://developer.spotify.com/web-api/get-followed-artists/">Get User's Followed Artists</a>
14121414
*/
14131415
@GET("/me/following?type=artist")
1414-
public ArtistsCursorPager getFollowedArtists(@QueryMap Map<String, Object> options);
1416+
ArtistsCursorPager getFollowedArtists(@QueryMap Map<String, Object> options);
14151417

14161418
/**
14171419
* Get the current user's followed artists.
14181420
*
14191421
* @param options Optional parameters. For list of supported parameters see
14201422
* <a href="https://developer.spotify.com/web-api/get-followed-artists/">endpoint documentation</a>
1421-
* @param callback Callback method.
1423+
* @param callback Callback method.
14221424
* @return An empty result
14231425
* @see <a href="https://developer.spotify.com/web-api/get-followed-artists/">Get User's Followed Artists</a>
14241426
*/
14251427
@GET("/me/following?type=artist")
1426-
public Result getFollowedArtists(@QueryMap Map<String, Object> options, Callback<ArtistsCursorPager> callback);
1428+
Result getFollowedArtists(@QueryMap Map<String, Object> options, Callback<ArtistsCursorPager> callback);
14271429

14281430
/**********
14291431
* Search *

spotify-api/src/test/resources/org.robolectric.Config.properties

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
sdk=21
2+
constants= com.spotify.webapi.android.BuildConfig
3+
manifest=src/main/AndroidManifest.xml

0 commit comments

Comments
 (0)