Skip to content

Commit 02735b0

Browse files
committed
Fixed findings
1 parent a84acbf commit 02735b0

File tree

5 files changed

+18
-19
lines changed

5 files changed

+18
-19
lines changed

api/src/main/java/io/kafbat/ui/serdes/builtin/sr/SchemaRegistrySerde.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ public Deserializer deserializer(String topic, Target type) {
287287
return (headers, data) -> {
288288
var schemaId = extractSchemaIdFromMsg(data);
289289
SchemaType format = getMessageFormatBySchemaId(schemaId);
290-
String name = getNameBySchemaId(schemaId);
290+
String name = getNameBySchemaId(schemaId);
291291
MessageFormatter formatter = schemaRegistryFormatters.get(format);
292292
return new DeserializeResult(
293293
formatter.format(topic, data),

frontend/src/components/Topics/Topic/Messages/MessageContent/AvroMetadata.tsx

+7-3
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,14 @@ export interface AvroMetadataProps {
66
deserializeProperties?: { [key: string]: any | undefined };
77
}
88

9-
const AvroMetadata: React.FC<AvroMetadataProps> = ({ deserializeProperties }) => {
9+
const AvroMetadata: React.FC<AvroMetadataProps> = ({
10+
deserializeProperties,
11+
}) => {
1012
if (
11-
!deserializeProperties || deserializeProperties.type !== 'AVRO' ||
12-
!deserializeProperties.name || !deserializeProperties.schemaId
13+
!deserializeProperties ||
14+
deserializeProperties.type !== 'AVRO' ||
15+
!deserializeProperties.name ||
16+
!deserializeProperties.schemaId
1317
) {
1418
return null;
1519
}

frontend/src/components/Topics/Topic/Messages/MessageContent/MessageContent.tsx

+5-6
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import EditorViewer from 'components/common/EditorViewer/EditorViewer';
33
import BytesFormatted from 'components/common/BytesFormatted/BytesFormatted';
44
import { SchemaType, TopicMessageTimestampTypeEnum } from 'generated-sources';
55
import { formatTimestamp } from 'lib/dateTimeHelpers';
6-
import AvroMetadata from './AvroMetadata';
76

7+
import AvroMetadata from './AvroMetadata';
88
import * as S from './MessageContent.styled';
99

1010
type Tab = 'key' | 'content' | 'headers';
@@ -122,8 +122,8 @@ const MessageContent: React.FC<MessageContentProps> = ({
122122
</S.MetadataMeta>
123123
</span>
124124
</S.Metadata>
125-
126-
<AvroMetadata deserializeProperties={keyDeserializeProperties} />
125+
126+
<AvroMetadata deserializeProperties={keyDeserializeProperties} />
127127

128128
<S.Metadata>
129129
<S.MetadataLabel>Value Serde</S.MetadataLabel>
@@ -134,9 +134,8 @@ const MessageContent: React.FC<MessageContentProps> = ({
134134
</S.MetadataMeta>
135135
</span>
136136
</S.Metadata>
137-
138-
<AvroMetadata deserializeProperties={valueDeserializeProperties} />
139-
137+
138+
<AvroMetadata deserializeProperties={valueDeserializeProperties} />
140139
</S.MetadataWrapper>
141140
</S.Section>
142141
</td>

frontend/src/components/Topics/Topic/Messages/MessageContent/__tests__/AvroMetadata.spec.tsx

+3-7
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,10 @@ import { TextEncoder } from 'util';
22

33
import React from 'react';
44
import { screen } from '@testing-library/react';
5-
import MessageContent, {
6-
MessageContentProps,
7-
} from 'components/Topics/Topic/Messages/MessageContent/MessageContent';
8-
import { TopicMessageTimestampTypeEnum } from 'generated-sources';
9-
import userEvent from '@testing-library/user-event';
105
import { render } from 'lib/testHelpers';
11-
import { theme } from 'theme/theme';
12-
import AvroMetadata, {AvroMetadataProps} from "../AvroMetadata";
6+
import AvroMetadata, {
7+
AvroMetadataProps,
8+
} from 'components/Topics/Topic/Messages/MessageContent/AvroMetadata';
139

1410
const setupWrapper = (props?: Partial<AvroMetadataProps>) => {
1511
return (

frontend/src/components/Topics/Topic/Messages/MessageContent/__tests__/MessageContent.spec.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ describe('MessageContent screen', () => {
4949
it('valueSerde in document', () => {
5050
expect(screen.getByText('Avro')).toBeInTheDocument();
5151
});
52-
53-
it('valueType in document', () => {
52+
53+
it('valueType in document', () => {
5454
expect(screen.getByText('Value Type')).toBeInTheDocument();
5555
});
5656
});

0 commit comments

Comments
 (0)