Skip to content

Commit 6cf9492

Browse files
germanosinHaarolean
authored andcommitted
Fixing comments
(cherry picked from commit 17e0624)
1 parent 1689458 commit 6cf9492

File tree

5 files changed

+48
-31
lines changed

5 files changed

+48
-31
lines changed

api/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ RUN chown kafkaui /etc/kafkaui
1717
USER kafkaui
1818

1919
ARG JAR_FILE
20-
COPY "/target/${JAR_FILE}" "/api.jar"
20+
COPY $JAR_FILE "/api.jar"
2121

2222
ENV JAVA_OPTS=
2323

api/build.gradle

+13-13
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ plugins {
44
id 'checkstyle'
55
alias(libs.plugins.spring.boot)
66
alias(libs.plugins.git.properties)
7-
alias(libs.plugins.jib)
7+
alias(libs.plugins.docker.remote.api)
88
}
99

10+
import com.bmuschko.gradle.docker.tasks.image.DockerBuildImage
11+
1012
dependencies {
1113
implementation project(":contract")
1214
if (prod) {
@@ -105,7 +107,7 @@ tasks.withType(Checkstyle) {
105107
}
106108

107109
checkstyle {
108-
toolVersion '10.3.1'
110+
toolVersion = libs.versions.checkstyle.get()
109111
configFile = rootProject.file('etc/checkstyle/checkstyle.xml')
110112
ignoreFailures = false
111113
maxWarnings = 0
@@ -116,15 +118,13 @@ test {
116118
useJUnitPlatform()
117119
}
118120

119-
jib {
120-
from {
121-
image = 'azul/zulu-openjdk-alpine:21.0.5-jre-headless'
122-
}
123-
to {
124-
image = 'ghcr.io/kafbat/kafka-ui'
125-
}
126-
container {
127-
user = "kafkaui"
128-
jvmFlags = ['--add-opens java.rmi/javax.rmi.ssl=ALL-UNNAMED']
129-
}
121+
tasks.register('buildDockerImage', DockerBuildImage) {
122+
inputDir = projectDir
123+
dockerFile = project.layout.projectDirectory.file('Dockerfile')
124+
buildArgs = [
125+
'JAR_FILE': "build/libs/${project.name}-${project.version}.jar"
126+
]
127+
images.add("ghcr.io/kafbat/kafka-ui:${project.version}")
130128
}
129+
130+
tasks.build.finalizedBy buildDockerImage

api/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@
522522
<build>
523523
<contextDir>${project.basedir}</contextDir>
524524
<args>
525-
<JAR_FILE>${project.build.finalName}.jar</JAR_FILE>
525+
<JAR_FILE>target/${project.build.finalName}.jar</JAR_FILE>
526526
</args>
527527
</build>
528528
</image>

e2e-tests/build.gradle

+10-16
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,18 @@ plugins {
44
alias(libs.plugins.allure)
55
}
66

7-
ext {
8-
kafkaVersion = "3.8.0"
9-
aspectjVersion = "1.9.21"
10-
allureVersion = "2.27.0"
11-
}
12-
137
dependencies {
148
implementation project(":contract")
15-
implementation "org.apache.kafka:kafka_2.13:${kafkaVersion}"
16-
implementation "org.aspectj:aspectjweaver:${aspectjVersion}"
17-
implementation "commons-io:commons-io:2.16.1"
18-
implementation "org.testng:testng:7.10.0"
19-
implementation "com.codeborne:selenide:7.2.3"
20-
implementation "io.qameta.allure:allure-testng:${allureVersion}"
21-
implementation "io.qameta.allure:allure-selenide:${allureVersion}"
22-
implementation "io.github.bonigarcia:webdrivermanager:5.8.0"
9+
implementation libs.apache.kafka
10+
implementation libs.apache.commons.io
11+
implementation libs.aspectj
12+
implementation libs.testng
13+
implementation libs.codeborne.selenide
14+
implementation libs.allure.testng
15+
implementation libs.allure.selenide
16+
implementation libs.bonigarcia.webdrivermanager
2317
implementation libs.spring.starter.webflux
24-
implementation "io.netty:netty-resolver-dns-native-macos:4.1.116.Final"
18+
implementation libs.netty.resolver.dns.native
2519

2620
implementation libs.lombok
2721

@@ -30,7 +24,7 @@ dependencies {
3024
}
3125

3226
checkstyle {
33-
toolVersion '10.3.1'
27+
toolVersion = libs.versions.checkstyle.get()
3428
configFile = rootProject.file('etc/checkstyle/checkstyle-e2e.xml')
3529
ignoreFailures = false
3630
maxWarnings = 10

gradle/libs.versions.toml

+23
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ aws-msk-auth = '2.2.0'
77
azure-identity = '1.14.2'
88

99
apache-commons = '2.12.0'
10+
apache-commons-io = '2.16.1'
1011
apache-datasketches = '3.1.0'
1112
apache-commons-compress = '1.26.0'
1213

@@ -37,6 +38,14 @@ project-reactor = '3.6.12'
3738
micrometer = '1.13.8'
3839
antlr = '4.12.0'
3940
json-schema-validator = '2.2.14'
41+
checkstyle = '10.3.1'
42+
allure = '2.27.0'
43+
codeborne-selenide = '7.2.3'
44+
testng = '7.10.0'
45+
bonigarcia-webdrivermanager = '5.8.0'
46+
aspectj = '1.9.21'
47+
kafka = '3.8.0'
48+
netty-resolver-dns-native = '4.1.116.Final'
4049

4150
[plugins]
4251
spring-boot = { id = 'org.springframework.boot', version = '3.4.1' }
@@ -46,6 +55,8 @@ allure = { id = 'io.qameta.allure', version='2.10.0' }
4655
nexus-publish-plugin = { id = 'io.github.gradle-nexus.publish-plugin', version = '1.1.0'}
4756
node-gradle = { id = 'com.github.node-gradle.node', version = '7.0.2'}
4857
jib = { id = 'com.google.cloud.tools.jib', version = '3.4.4' }
58+
docker-remote-api = { id = 'com.bmuschko.docker-remote-api', version = '9.4.0'}
59+
4960

5061

5162

@@ -74,9 +85,11 @@ kafka-clients = { module = 'org.apache.kafka:kafka-clients', version.ref = 'kafk
7485

7586
apache-commons = { module = 'org.apache.commons:commons-lang3', version.ref = 'apache-commons'}
7687
apache-commons-compress = { module = 'org.apache.commons:commons-compress', version.ref = 'apache-commons-compress'}
88+
apache-commons-io = { module = 'commons-io:commons-io', version.ref = 'apache-commons-io'}
7789
apache-commons-pool2 = { module = 'org.apache.commons:commons-pool2', version.ref = 'apache-commons'}
7890
apache-datasketches = { module = 'org.apache.datasketches:datasketches-java', version.ref='apache-datasketches'}
7991
apache-avro = { module = 'org.apache.avro:avro', version.ref = 'avro'}
92+
apache-kafka = { module = 'org.apache.kafka:kafka_2.13', version.ref = 'kafka'}
8093

8194
confluent-schema-registry-client = { module = 'io.confluent:kafka-schema-registry-client', version.ref = 'confluent'}
8295
confluent-avro-serializer = { module = 'io.confluent:kafka-avro-serializer', version.ref = 'confluent'}
@@ -111,3 +124,13 @@ opendatadiscovery-client = { module = 'org.opendatadiscovery:ingestion-contract-
111124
bytebuddy = {module = 'net.bytebuddy:byte-buddy', version.ref='byte-buddy'}
112125
assertj = {module = 'org.assertj:assertj-core', version.ref = 'assertj'}
113126
jsonschemavalidator = {module = 'com.github.java-json-tools:json-schema-validator', version.ref ='json-schema-validator'}
127+
128+
allure-testng = { module = 'io.qameta.allure:allure-testng', version.ref = 'allure' }
129+
allure-selenide = { module = 'io.qameta.allure:allure-selenide', version.ref = 'allure' }
130+
131+
codeborne-selenide = { module = 'com.codeborne:selenide', version.ref = 'codeborne-selenide'}
132+
testng = { module = 'org.testng:testng', version.ref = 'testng'}
133+
aspectj = { module = 'org.aspectj:aspectjweaver', version.ref = 'aspectj'}
134+
bonigarcia-webdrivermanager = { module = 'io.github.bonigarcia:webdrivermanager', version.ref = 'bonigarcia-webdrivermanager'}
135+
netty-resolver-dns-native = { module = 'io.netty:netty-resolver-dns-native-macos', version.ref = 'netty-resolver-dns-native'}
136+

0 commit comments

Comments
 (0)