👨‍💻 Upgrade codebase with using .includes() instead of .indexOf() for strings

Author: dr-dimitru

core.js

@@ -134,7 +134,7 @@ export default class FilesCollectionCore extends EventEmitter {
    * @returns {Object}
    */
   _getExt(fileName) {
-    if (!!~fileName.indexOf('.')) {
+    if (fileName.includes('.')) {
       const extension = (fileName.split('.').pop().split('?')[0] || '').toLowerCase();
       return { ext: extension, extension, extensionWithDot: `.${extension}` };
     }

lib.js

@@ -123,7 +123,7 @@ for (let i = 0; i < _helpers.length; i++) {
  */
 const fixJSONParse = function(obj) {
   for (let key in obj) {
-    if (helpers.isString(obj[key]) && !!~obj[key].indexOf('=--JSON-DATE--=')) {
+    if (helpers.isString(obj[key]) && obj[key].includes('=--JSON-DATE--=')) {
       obj[key] = obj[key].replace('=--JSON-DATE--=', '');
       obj[key] = new Date(parseInt(obj[key]));
     } else if (helpers.isObject(obj[key])) {
@@ -134,7 +134,7 @@ const fixJSONParse = function(obj) {
         v = obj[key][i];
         if (helpers.isObject(v)) {
           obj[key][i] = fixJSONParse(v);
-        } else if (helpers.isString(v) && !!~v.indexOf('=--JSON-DATE--=')) {
+        } else if (helpers.isString(v) && v.includes('=--JSON-DATE--=')) {
           v = v.replace('=--JSON-DATE--=', '');
           obj[key][i] = new Date(parseInt(v));
         }

upload.js

@@ -157,11 +157,11 @@ export class UploadInstance extends EventEmitter {
         throw new Meteor.Error(400, '"fileName" must me specified for base64 upload!');
       }
 
-      if (!!~this.config.file.indexOf('data:')) {
+      if (this.config.file.includes('data:')) {
         this.config.file = this.config.file.replace('data:', '');
       }
 
-      if (!!~this.config.file.indexOf(',')) {
+      if (this.config.file.includes(',')) {
         const _file = this.config.file.split(',');
         this.fileData = {
           size: Math.floor(((_file[1].replace(/\=/g, '')).length / 4) * 3),