Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithContext should return ctx.Done channel #126

Closed
kamilsk opened this issue Dec 15, 2017 · 1 comment
Closed

WithContext should return ctx.Done channel #126

kamilsk opened this issue Dec 15, 2017 · 1 comment
Assignees
@kamilsk
Labels
help wanted type:task
Milestone
semaphore 5.0

Comments

@kamilsk
Copy link
Owner

kamilsk commented Dec 15, 2017 

semaphore.Acquire(semaphore.Multiplex(semaphore.WithContext(req.Context()), semaphore.WithSignal(os.Interrupt)))

like as errgroup:

g, ctx := errgroup.WithContext(ctx)

https://github.com/golang/sync/tree/master/errgroup
@kamilsk kamilsk added this to the semaphore 5.0 milestone Dec 15, 2017
@kamilsk kamilsk self-assigned this Dec 15, 2017
@kamilsk
Copy link
Owner Author

kamilsk commented Feb 26, 2019

will be removed by #133

@kamilsk kamilsk closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
help wanted type:task
Projects
None yet
Milestone
semaphore 5.0
Development

No branches or pull requests
1 participant
@kamilsk