Kamu 108 Unit Tests Coverage (#51)

* Upgraded to latest version of Jasmine framework
* Written over 200 unit tests for almost all existing components and services
* Corrections in the code detected by unit tests
* Configured coverage reporting during testing
* Enabled Jasmine plugin for ESLint
* Upgraded to latest GraphQL schema

Author: dmitriy-borzenko

.eslintrc

@@ -9,15 +9,18 @@
     "plugin:@typescript-eslint/recommended",
     "plugin:@typescript-eslint/recommended-requiring-type-checking",
     "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/strict"
+    "plugin:@typescript-eslint/strict",
+    "plugin:jasmine/recommended"
   ],
   "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint"],
+  "plugins": ["@typescript-eslint", "jasmine"],
+  "env": {
+    "jasmine": true
+  },
   "rules": {
     "no-bitwise": 0,
-    "@typescript-eslint/no-extraneous-class": [
-      "off"
-    ]
+    "@typescript-eslint/no-extraneous-class": ["off"],
+    "jasmine/new-line-before-expect": 0
   },
   "ignorePatterns": ["node_modules", "dist", "kamu.graphql.interface.ts"]
 }

.gitignore

@@ -1,3 +1,4 @@
 /.angular/cache
 /node_modules
 /dist
+/coverage

e2e/src/app.e2e-spec.ts

@@ -8,18 +8,24 @@ describe("workspace-project App", () => {
         page = new AppPage();
     });
 
-    it("should display welcome message", async () => {
-        await page.navigateTo();
-        await expect(page.getTitleText()).toEqual("kamu-platform app is running!");
-    });
-
-    afterEach(async () => {
-        // Assert that there are no errors emitted from the browser
+    async function checkNoErrorsInLog(): Promise<void> {
         const logs = await browser.manage().logs().get(logging.Type.BROWSER);
         expect(logs).not.toContain(
             jasmine.objectContaining({
                 level: logging.Level.SEVERE,
             } as logging.Entry),
         );
+    }
+
+    it("should display welcome message", async () => {
+        await page.navigateTo();
+        expect(await page.getTitleText()).toEqual(
+            "kamu-platform app is running!",
+        );
+    });
+
+    afterEach(async () => {
+        // Assert that there are no errors emitted from the browser
+        await checkNoErrorsInLog();
     });
 });

e2e/tsconfig.json

@@ -6,8 +6,7 @@
     "target": "es2018",
     "types": [
       "jasmine",
-      "jasminewd2",
       "node"
     ]
   }
-}
+}

karma.conf.js

@@ -8,7 +8,7 @@ module.exports = function (config) {
     plugins: [
       require("karma-jasmine"),
       require("karma-chrome-launcher"),
-      require('karma-firefox-launcher'),
+      require("karma-firefox-launcher"),
       require("karma-jasmine-html-reporter"),
       require("karma-coverage-istanbul-reporter"),
       require("@angular-devkit/build-angular/plugins/karma"),
@@ -21,7 +21,7 @@ module.exports = function (config) {
       reports: ["html", "lcovonly", "text-summary"],
       fixWebpackSourcePaths: true,
     },
-    reporters: ["progress", "kjhtml"],
+    reporters: ["progress", "kjhtml", "coverage-istanbul"],
     port: 9876,
     colors: true,
     logLevel: config.LOG_INFO,

package-lock.json

@@ -6,8 +6,8 @@
     "start": "ng serve --watch",
     "build": "ng build",
     "build-prod": "ng build --configuration production",
-    "test": "ng test --no-watch --no-progress --browsers ChromeHeadless",
-    "test-firefox": "ng test --no-progress --browsers Firefox",
+    "test": "ng test --no-watch --no-progress --browsers ChromeHeadless --code-coverage",
+    "test-firefox": "ng test --no-progress --browsers Firefox --code-coverage",
     "lint": "eslint . --ext .ts",
     "lint-and-fix": "eslint . --ext .ts --fix",
     "e2e": "ng e2e",
@@ -64,26 +64,27 @@
     "@graphql-codegen/cli": "^2.11.8",
     "@graphql-codegen/typescript-apollo-angular": "^3.3.1",
     "@graphql-codegen/typescript-operations": "^2.2.1",
-    "@types/jasmine": "~3.4.0",
-    "@types/jasminewd2": "~2.0.3",
+    "@types/jasmine": "^4.3.0",
     "@types/lodash": "^4.14.182",
     "@types/node": "9.6.0",
     "@typescript-eslint/eslint-plugin": "^5.33.1",
     "@typescript-eslint/parser": "^5.33.1",
     "codelyzer": "^5.1.2",
     "eslint": "^8.22.0",
+    "eslint-plugin-jasmine": "^4.1.3",
     "husky": "^8.0.0",
-    "jasmine-core": "~3.5.0",
-    "jasmine-spec-reporter": "~5.0.0",
+    "jasmine": "^4.4.0",
+    "jasmine-spec-reporter": "^7.0.0",
     "karma": "~6.4.0",
     "karma-chrome-launcher": "~3.1.0",
     "karma-coverage-istanbul-reporter": "~3.0.2",
     "karma-firefox-launcher": "^2.1.2",
-    "karma-jasmine": "~4.0.0",
-    "karma-jasmine-html-reporter": "^1.5.0",
+    "karma-jasmine": "^5.1.0",
+    "karma-jasmine-html-reporter": "^2.0.0",
     "prettier": "2.5.1",
     "pretty-quick": "^3.1.3",
     "protractor": "~7.0.0",
+    "timekeeper": "^2.2.0",
     "ts-node": "~8.3.0",
     "typescript": "4.6.4"
   }

package.json

@@ -163,7 +163,7 @@ type DatasetConnection {
 	"""
 	Approximate number of total nodes
 	"""
-	totalCount: Int
+	totalCount: Int!
 	"""
 	Page information
 	"""
@@ -313,6 +313,7 @@ type FetchStepUrl {
 	url: String!
 	eventTime: EventTimeSource
 	cache: SourceCaching
+	headers: [RequestHeader!]
 }
 
 
@@ -356,7 +357,7 @@ type MetadataBlockConnection {
 	"""
 	Approximate number of total nodes
 	"""
-	totalCount: Int
+	totalCount: Int!
 	"""
 	Page information
 	"""
@@ -374,6 +375,7 @@ type MetadataBlockExtended {
 	systemTime: DateTime!
 	author: Account!
 	event: MetadataEvent!
+	sequenceNumber: Int!
 }
 
 type MetadataChain {
@@ -518,6 +520,11 @@ type ReadStepParquet {
 	schema: [String!]
 }
 
+type RequestHeader {
+	name: String!
+	value: String!
+}
+
 type Search {
 	"""
 	Perform search across all resources
@@ -535,7 +542,7 @@ type SearchResultConnection {
 	"""
 	Approximate number of total nodes
 	"""
-	totalCount: Int
+	totalCount: Int!
 	"""
 	Page information
 	"""