Skip to content

Commit aa8829d

Browse files
Type corrected in feature flags (#484)
1 parent 0b23c75 commit aa8829d

File tree

8 files changed

+12
-9
lines changed

8 files changed

+12
-9
lines changed

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313
### Changed
1414
- Readme section: modified 'Run' button into a link
1515
- Hint extension for tile widget account
16+
### Fixed
17+
- Typo in feature flags (enableDatasetEnvVarsManagement)
18+
^
1619

1720
## [0.31.0] - 2024-11-22
1821
### Added
@@ -143,7 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
143146
### Added
144147
- Added access token feature
145148
- Added environment variables and secrets for the dataset
146-
- Added new flag(enableDatasetEnvVarsManagment) in the runtime configuration
149+
- Added new flag(enableDatasetEnvVarsManagement) in the runtime configuration
147150
### Fixed
148151
- Fixed bug with cache(Data tab) on the deployment version
149152
- Extended full source info for EthereumLogs(Metadata tab)

src/app/app-config.model.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export enum LoginMethod {
2121
export interface AppConfigFeatureFlags {
2222
enableLogout: boolean;
2323
enableScheduling: boolean;
24-
enableDatasetEnvVarsManagment: boolean;
24+
enableDatasetEnvVarsManagement: boolean;
2525
enableTermsOfService: boolean;
2626
}
2727

src/app/app.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export class AppComponent extends BaseComponent implements OnInit {
4040
public static readonly DEFAULT_FEATURE_FLAGS: AppConfigFeatureFlags = {
4141
enableLogout: true,
4242
enableScheduling: true,
43-
enableDatasetEnvVarsManagment: true,
43+
enableDatasetEnvVarsManagement: true,
4444
enableTermsOfService: true,
4545
};
4646

src/app/auth/login/login.component.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ describe("LoginComponent", () => {
4242
const MOCK_FEATURE_FLAGS = {
4343
enableLogout: true,
4444
enableScheduling: true,
45-
enableDatasetEnvVarsManagment: true,
45+
enableDatasetEnvVarsManagement: true,
4646
enableTermsOfService: true,
4747
};
4848

src/app/components/app-header/app-header.component.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe("AppHeaderComponent", () => {
8686
component.featureFlags = {
8787
enableLogout: true,
8888
enableScheduling: true,
89-
enableDatasetEnvVarsManagment: true,
89+
enableDatasetEnvVarsManagement: true,
9090
enableTermsOfService: true,
9191
};
9292
component.loginMethods = [LoginMethod.GITHUB, LoginMethod.PASSWORD];

src/app/components/data-access-panel/data-access-modal/data-access-modal.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class DataAccessModalComponent {
4242

4343
public get showApiTokensLink(): boolean {
4444
return (
45-
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
45+
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
4646
this.loggedUserService.isAuthenticated &&
4747
this.datasetBasics.kind === DatasetKind.Root
4848
);

src/app/dataset-view/additional-components/dataset-settings-component/dataset-settings.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {
6666

6767
public get showSecretsManagerTab(): boolean {
6868
return (
69-
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
69+
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
7070
this.activeTab === SettingsTabsEnum.VARIABLES_AND_SECRETS
7171
);
7272
}
@@ -104,7 +104,7 @@ export class DatasetSettingsComponent extends BaseComponent implements OnInit {
104104
return this.datasetBasics.kind === DatasetKind.Root;
105105
case SettingsTabsEnum.VARIABLES_AND_SECRETS:
106106
return (
107-
this.appConfigService.featureFlags.enableDatasetEnvVarsManagment &&
107+
this.appConfigService.featureFlags.enableDatasetEnvVarsManagement &&
108108
this.datasetBasics.kind === DatasetKind.Root
109109
);
110110
default:

src/assets/runtime-config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"featureFlags": {
77
"enableLogout": true,
88
"enableScheduling": true,
9-
"enableDatasetEnvVarsManagment": true,
9+
"enableDatasetEnvVarsManagement": true,
1010
"enableTermsOfService": true
1111
},
1212
"grafanaLogs": {

0 commit comments

Comments
 (0)